From: Daniel Borkmann <daniel@iogearbox.net>
To: Richard Weinberger <richard@sigma-star.at>,
Randy Dunlap <rdunlap@infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
alexei.starovoitov@gmail.com, brueckner@linux.vnet.ibm.com
Subject: Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)
Date: Mon, 11 Dec 2017 11:19:54 +0100 [thread overview]
Message-ID: <ea01fc20-a122-e6d3-e147-2de7f9fa7e47@iogearbox.net> (raw)
In-Reply-To: <7534692.EB8JgYtGIt@blindfold>
Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ]
On 12/11/2017 09:32 AM, Richard Weinberger wrote:
> Randy,
>
> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap:
>> On 12/10/2017 06:08 PM, Linus Torvalds wrote:
>>> Another week, another rc.
>>
>> um (uml) won't build on i386 or x86_64:
>>
>> CC init/main.o
>> In file included from ../include/linux/perf_event.h:18:0,
>> from ../include/linux/trace_events.h:10,
>> from ../include/trace/syscall.h:7,
>> from ../include/linux/syscalls.h:82,
>> from ../init/main.c:20:
>> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error:
>> asm/bpf_perf_event.h: No such file or directory #include
>> <asm/bpf_perf_event.h>
>> ^
>> compilation terminated.
>> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed
>
> How do you trigger that build failure?
> Can you share your .config?
Hmm, too bad kbuild bot doesn't catch issues on uml. I'm not too familiar
with uml, but looks like it's the only special case where there's no
arch/um/include/uapi/asm/. What is the usual convention to pull in such
headers in this case? Something like the below, would that fix it for you?
Thanks for your help,
Daniel
arch/um/include/asm/bpf_perf_event.h | 1 +
include/asm-generic/bpf_perf_event.h | 1 +
2 files changed, 2 insertions(+)
create mode 100644 arch/um/include/asm/bpf_perf_event.h
create mode 100644 include/asm-generic/bpf_perf_event.h
diff --git a/arch/um/include/asm/bpf_perf_event.h b/arch/um/include/asm/bpf_perf_event.h
new file mode 100644
index 0000000..3097758
--- /dev/null
+++ b/arch/um/include/asm/bpf_perf_event.h
@@ -0,0 +1 @@
+#include <asm-generic/bpf_perf_event.h>
diff --git a/include/asm-generic/bpf_perf_event.h b/include/asm-generic/bpf_perf_event.h
new file mode 100644
index 0000000..67112e5
--- /dev/null
+++ b/include/asm-generic/bpf_perf_event.h
@@ -0,0 +1 @@
+#include <uapi/asm-generic/bpf_perf_event.h>
--
2.9.5
next prev parent reply other threads:[~2017-12-11 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+55aFz9O9R8u3ori-QNPz4ALU+0B=Es0gd+oWmsce5qxugxXA@mail.gmail.com>
2017-12-11 2:42 ` Linux 4.15-rc3 (uml + bpf_perf_event.h) Randy Dunlap
2017-12-11 8:32 ` Richard Weinberger
2017-12-11 10:19 ` Daniel Borkmann [this message]
2017-12-11 17:27 ` Randy Dunlap
2017-12-11 17:32 ` Daniel Borkmann
2017-12-11 18:19 ` Richard Weinberger
2017-12-11 18:49 ` Richard Weinberger
2017-12-11 18:56 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea01fc20-a122-e6d3-e147-2de7f9fa7e47@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=richard@sigma-star.at \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).