From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Tom Herbert <tom@herbertland.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [Patch net] net: invert the check of detecting hardware RX checksum fault
Date: Mon, 19 Nov 2018 17:47:33 -0800 [thread overview]
Message-ID: <ea0aec4d-9051-cd04-4524-bcd747312216@gmail.com> (raw)
In-Reply-To: <CAM_iQpWyEr1xQ_c_yZf8NfULBsm=kv_-xN4PB0tT=RxCAz1c5A@mail.gmail.com>
On 11/19/2018 05:42 PM, Cong Wang wrote:
> On Fri, Nov 16, 2018 at 12:15 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>
>> On Thu, Nov 15, 2018 at 8:52 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>>
>>> You could use trafgen to cook such a frame and confirm the theory.
>>>
>>> Something like :
>>
>> I will try it.
>
> I just tried it, it doesn't make much difference, the warning only
> shows up once after I ran the trafgen script for many times,
> it could be triggered by other daemons running on the host too.
I guess we will need to dump the whole packet for debugging,
as suggest by Herbert :/
next prev parent reply other threads:[~2018-11-20 12:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 23:16 [Patch net] net: invert the check of detecting hardware RX checksum fault Cong Wang
2018-11-16 1:52 ` Herbert Xu
2018-11-16 2:23 ` Cong Wang
2018-11-16 4:50 ` Herbert Xu
2018-11-16 20:06 ` Cong Wang
2018-11-16 21:32 ` Cong Wang
2018-11-19 4:01 ` Herbert Xu
2018-11-19 19:25 ` Cong Wang
2018-11-20 3:09 ` Herbert Xu
2018-11-22 1:25 ` Paweł Staszewski
2018-11-16 4:52 ` Eric Dumazet
2018-11-16 4:59 ` Herbert Xu
2018-11-16 20:10 ` Cong Wang
2018-11-16 20:15 ` Cong Wang
2018-11-16 21:33 ` Eric Dumazet
2018-11-20 1:42 ` Cong Wang
2018-11-20 1:47 ` Eric Dumazet [this message]
2018-11-20 18:13 ` David Miller
2018-11-20 18:18 ` Eric Dumazet
2018-11-21 3:35 ` Herbert Xu
2018-11-18 0:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea0aec4d-9051-cd04-4524-bcd747312216@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox