From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [Patch net] net: invert the check of detecting hardware RX checksum fault Date: Mon, 19 Nov 2018 17:47:33 -0800 Message-ID: References: <20181115231602.18328-1-xiyou.wangcong@gmail.com> <20181116015242.wmm6mooubjnum7qv@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Herbert Xu , Linux Kernel Network Developers , Tom Herbert , Eric Dumazet , Saeed Mahameed To: Cong Wang , Eric Dumazet Return-path: Received: from mail-pl1-f171.google.com ([209.85.214.171]:44898 "EHLO mail-pl1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbeKTMOL (ORCPT ); Tue, 20 Nov 2018 07:14:11 -0500 Received: by mail-pl1-f171.google.com with SMTP id s5-v6so152515plq.11 for ; Mon, 19 Nov 2018 17:47:35 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/19/2018 05:42 PM, Cong Wang wrote: > On Fri, Nov 16, 2018 at 12:15 PM Cong Wang wrote: >> >> On Thu, Nov 15, 2018 at 8:52 PM Eric Dumazet wrote: >>> >>> You could use trafgen to cook such a frame and confirm the theory. >>> >>> Something like : >> >> I will try it. > > I just tried it, it doesn't make much difference, the warning only > shows up once after I ran the trafgen script for many times, > it could be triggered by other daemons running on the host too. I guess we will need to dump the whole packet for debugging, as suggest by Herbert :/