From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [Patch net-next] net_sched: add performance counters for basic filter
Date: Sun, 3 Feb 2019 10:35:55 -0800 [thread overview]
Message-ID: <ea0ef016-8d87-f358-0c80-a3d42da7fae4@gmail.com> (raw)
In-Reply-To: <20190118011401.28220-1-xiyou.wangcong@gmail.com>
On 01/17/2019 05:14 PM, Cong Wang wrote:
> Similar to u32 filter, it is useful to know how many times
> we reach each basic filter and how many times we pass the
> ematch attached to it.
>
> Sample output:
>
> filter protocol arp pref 49152 basic chain 0
> filter protocol arp pref 49152 basic chain 0 handle 0x1 (rule hit 3 success 3)
> action order 1: gact action pass
> random type none pass val 0
> index 1 ref 1 bind 1 installed 81 sec used 4 sec
> Action statistics:
> Sent 126 bytes 3 pkt (dropped 0, overlimits 0 requeues 0)
> backlog 0b 0p requeues 0
...
> + for_each_possible_cpu(cpu) {
> + struct tc_basic_pcnt *pf = per_cpu_ptr(f->pf, cpu);
> +
> + gpf.rcnt += pf->rcnt;
> + gpf.rhit += pf->rhit;
> + }
>
This looks missing some synchronization of some sort for 32bit kernels ?
next prev parent reply other threads:[~2019-02-03 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 1:14 [Patch net-next] net_sched: add performance counters for basic filter Cong Wang
2019-01-20 0:06 ` David Miller
2019-02-03 18:35 ` Eric Dumazet [this message]
2019-02-03 19:35 ` Cong Wang
2019-02-04 3:27 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea0ef016-8d87-f358-0c80-a3d42da7fae4@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).