From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DBFC169C4 for ; Sun, 3 Feb 2019 18:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 045AD217D9 for ; Sun, 3 Feb 2019 18:36:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bBB8Bhh9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727809AbfBCSf7 (ORCPT ); Sun, 3 Feb 2019 13:35:59 -0500 Received: from mail-yb1-f173.google.com ([209.85.219.173]:39597 "EHLO mail-yb1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726553AbfBCSf7 (ORCPT ); Sun, 3 Feb 2019 13:35:59 -0500 Received: by mail-yb1-f173.google.com with SMTP id s17so4764472ybp.6 for ; Sun, 03 Feb 2019 10:35:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w5rSKrEydsna74JfiSJd1KEvc/ZHVzk6xccIrLn9018=; b=bBB8Bhh9XQaHO+aNGb1oUUXAEkSGrNw9JtSRRNb3asv1laW/H2pEFn1PM20PGOoEzB 25ZC6JPALQCqeri4BlpIyh5HmvYDWkQ+hG2HzMcUszWKj8n3rfNB20Bq70KISVmrIr7l suNMpolyLJcXZGGm3Rg6eUm0GTfVToZcEaa1UmTLAEGEHB/2I4pfyl6GYQBTrbHAOaay YKzSAYCaKhSZZP4LTTCNH2nuRPHVzRLq5gCyl30HDsPTC3pF+8Ba+9ot/kD8Thy/VQCV pcsWar4aZQctqCHQlaN6GNLaDHRzpNnhsSP7Tfu0sx3i/PqKUjg1/Q23jRI3SgUMkf7U xPDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w5rSKrEydsna74JfiSJd1KEvc/ZHVzk6xccIrLn9018=; b=aJlus3edDWRB0b7QdqGU7mAMcor+LydipUPPXzkvdMf17BIsbKJAMwsgtP9Q0y/yoC JL3TOEANji1ZYwWyKhp0RLPM9Gigp8VrJBFEUqa5jGBlpLX2ZrcpGNlGiju6HQpFSMih dYQubX8ZhOWKl84emufpFskvLXlbJ9kdBRf3XiSq1TXMVhgp/mAAZyJw63Z7RstU57tk j7Lfc1ljn/FQqGBj7Xo2RIjeCy9aojemMvmB+Vmdxxy5OXdrElDrbQ4hFZ1JJP3erxF0 fmUXYRZ2lkn4Cz6MlZyfiZd0QcBvNQljJ/HyTe5SXGq9/plfghqD0SxaGKRb8oauAsv6 +3DQ== X-Gm-Message-State: AHQUAuZwuxTdU14LJUvGEi5Z+kk6IU/ad9a3d4iEQ/Na/XOSmSY3dUk6 KiqhZCgrkJQHKQ2kIqrVRds= X-Google-Smtp-Source: AHgI3IaSE+cZtl0qBNcx9yakcJ85kNV3sKUzCNfwpyCO2Zmr2SxTv3RPwKz22AgzclZ7eNAQORxRYA== X-Received: by 2002:a25:505:: with SMTP id 5mr28266517ybf.389.1549218958375; Sun, 03 Feb 2019 10:35:58 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id l3sm454918ywb.39.2019.02.03.10.35.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Feb 2019 10:35:57 -0800 (PST) Subject: Re: [Patch net-next] net_sched: add performance counters for basic filter To: Cong Wang , netdev@vger.kernel.org Cc: Jamal Hadi Salim , Jiri Pirko References: <20190118011401.28220-1-xiyou.wangcong@gmail.com> From: Eric Dumazet Message-ID: Date: Sun, 3 Feb 2019 10:35:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190118011401.28220-1-xiyou.wangcong@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/17/2019 05:14 PM, Cong Wang wrote: > Similar to u32 filter, it is useful to know how many times > we reach each basic filter and how many times we pass the > ematch attached to it. > > Sample output: > > filter protocol arp pref 49152 basic chain 0 > filter protocol arp pref 49152 basic chain 0 handle 0x1 (rule hit 3 success 3) > action order 1: gact action pass > random type none pass val 0 > index 1 ref 1 bind 1 installed 81 sec used 4 sec > Action statistics: > Sent 126 bytes 3 pkt (dropped 0, overlimits 0 requeues 0) > backlog 0b 0p requeues 0 ... > + for_each_possible_cpu(cpu) { > + struct tc_basic_pcnt *pf = per_cpu_ptr(f->pf, cpu); > + > + gpf.rcnt += pf->rcnt; > + gpf.rhit += pf->rhit; > + } > This looks missing some synchronization of some sort for 32bit kernels ?