From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Pavel Belous <Pavel.Belous@aquantia.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
Simon Edelhaus <Simon.Edelhaus@aquantia.com>,
Alexey Andriyanov <Alexey.Andriyanov@aquantia.com>
Subject: Re: [PATCH net-next 01/13] net: ethernet: aquantia: Removed extra assignment for skb->dev.
Date: Wed, 15 Feb 2017 21:53:54 +0100 [thread overview]
Message-ID: <ea14de65-6ad8-7601-aadc-6be1fc1ebb88@gmx.de> (raw)
In-Reply-To: <31d152c1fba6779d0ed1a00c620cba34db3df8a2.1487187192.git.pavel.belous@aquantia.com>
Hi,
On 15.02.2017 21:01, Pavel Belous wrote:
> From: Pavel Belous <pavel.belous@aquantia.com>
>
> This assignment is not needed.
>
> Signed-off-by: Pavel Belous <pavel.belous@aquantia.com>
> ---
> drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> index dea9e9b..4c40644 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> @@ -214,7 +214,6 @@ int aq_ring_rx_clean(struct aq_ring_s *self, int *work_done, int budget)
> goto err_exit;
> }
>
> - skb->dev = ndev;
> skb_put(skb, buff->len);
> } else {
> skb = netdev_alloc_skb(ndev, ETH_HLEN);
>
Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
next prev parent reply other threads:[~2017-02-15 20:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 20:01 [PATCH net-next 00/13] net: ethernet: aquantia: improvements and fixes Pavel Belous
2017-02-15 20:01 ` [PATCH net-next 01/13] net: ethernet: aquantia: Removed extra assignment for skb->dev Pavel Belous
2017-02-15 20:53 ` Lino Sanfilippo [this message]
2017-02-15 20:01 ` [PATCH net-next 02/13] net: ethernet: aquantia: Removed busy_count field Pavel Belous
2017-02-15 20:56 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 03/13] net: ethernet: aquantia: Removed unnecessary comparsion "old_mtu == new_mtu" Pavel Belous
2017-02-15 20:56 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 04/13] net: ethernet: aquantia: Using module_pci_driver Pavel Belous
2017-02-15 20:57 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 05/13] net: ethernet: aquantia: Superfluous initialization of "err" Pavel Belous
2017-02-15 21:01 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 06/13] net: ethernet: aquantia: Fixed missing rtnl_unlock Pavel Belous
2017-02-15 21:02 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 07/13] net: ethernet: aquantia: Using NETDEV_TX_OK instead 0 Pavel Belous
2017-02-15 21:02 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 08/13] net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc Pavel Belous
2017-02-15 21:04 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 09/13] net: ethernet: aquantia: Call netdev_register after all initialized Pavel Belous
2017-02-15 21:18 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 10/13] net: ethernet: aquantia: Checking for success dma_map_single Pavel Belous
2017-02-15 21:23 ` Lino Sanfilippo
2017-02-15 21:40 ` Lino Sanfilippo
2017-02-15 21:47 ` Pavel Belous
2017-02-15 20:01 ` [PATCH net-next 11/13] net: ethernet: aquantia: Refactoring buffers copying Pavel Belous
2017-02-15 21:31 ` Lino Sanfilippo
2017-02-15 21:50 ` Pavel Belous
2017-02-16 13:10 ` David Laight
2017-02-16 16:02 ` Lino Sanfilippo
2017-02-16 16:37 ` David Laight
2017-02-19 10:36 ` Lino Sanfilippo
2017-02-15 20:01 ` [PATCH net-next 12/13] net: ethernet: aquantia: Fixed incorrect buff->len calculation Pavel Belous
2017-02-15 20:01 ` [PATCH net-next 13/13] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page Pavel Belous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea14de65-6ad8-7601-aadc-6be1fc1ebb88@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=Alexey.Andriyanov@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=Simon.Edelhaus@aquantia.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).