Re: [PATCH] xfrm: SAD entries do not expire after suspend-resume

[Yury Polyanskiy <ypolyans@princeton.edu>]

On Mon, May 11, 2009 at 2:30 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, 2009-05-11 at 14:21 -0400, Yury Polyanskiy wrote:

>> (2) it can not be ported to anything post 2.6.28-rc7 because hrtimer's
>> callbacks are run in hardirq context ever since. This would require a
>> major rewrite of xfrm_state's locking (i.e. replacing spin_lock_bh()
>> with spin_lock_irqsave() at least) which is (a) outside of my competence
>> and (b) will introduce excessive irq-disabled codepaths.
>>
>>   Due to (2) I am copying the authors of the hrtimer's patch. Unless
>> there is an alternative (to hrtimer_start) way of requesting a
>> CLOCK_REALTIME softirq callback the only solution I could think of is
>> to hook into PM_POST_HIBERNATION+PM_POST_SUSPEND and force all of the
>> timers on xfrm_state_all list to go off after resume.
>
> Given that the whole problem is suspend related, this last option sounds
> like the best thing.
>

Can somebody from the Networking Team please confirm that the other
sources of time leaps can indeed be neglected? (such as ntp
corrections e.g.)

Best,
YP