From: Jacob Keller <jacob.e.keller@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, thomas.lendacky@amd.com,
aelior@marvell.com, GR-everest-linux-l2@marvell.com,
michael.chan@broadcom.com, rajur@chelsio.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
tariqt@nvidia.com, saeedm@nvidia.com,
GR-Linux-NIC-Dev@marvell.com, ecree.xilinx@gmail.com,
simon.horman@netronome.com, alexander.duyck@gmail.com
Subject: Re: [PATCH net-next 0/4] udp_tunnel_nic: post conversion cleanup
Date: Thu, 7 Jan 2021 10:44:11 -0800 [thread overview]
Message-ID: <ea428429-eb5f-166c-1773-acc7aa824731@intel.com> (raw)
In-Reply-To: <20210106210637.1839662-1-kuba@kernel.org>
On 1/6/2021 1:06 PM, Jakub Kicinski wrote:
> It has been two releases since we added the common infra for UDP
> tunnel port offload, and we have not heard of any major issues.
> Remove the old direct driver NDOs completely, and perform minor
> simplifications in the tunnel drivers.
>
Nice to see this step! Everything seems straight forward to me.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Jakub Kicinski (4):
> udp_tunnel: hard-wire NDOs to udp_tunnel_nic_*_port() helpers
> udp_tunnel: remove REGISTER/UNREGISTER handling from tunnel drivers
> net: remove ndo_udp_tunnel_* callbacks
> udp_tunnel: reshuffle NETIF_F_RX_UDP_TUNNEL_PORT checks
>
> drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 --
> .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 --
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 --
> .../net/ethernet/cavium/liquidio/lio_main.c | 2 --
> .../ethernet/cavium/liquidio/lio_vf_main.c | 2 --
> .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 --
> drivers/net/ethernet/cisco/enic/enic_main.c | 4 ----
> drivers/net/ethernet/emulex/benet/be_main.c | 2 --
> .../net/ethernet/intel/fm10k/fm10k_netdev.c | 2 --
> drivers/net/ethernet/intel/i40e/i40e_main.c | 2 --
> drivers/net/ethernet/intel/ice/ice_main.c | 2 --
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 --
> .../net/ethernet/mellanox/mlx4/en_netdev.c | 4 ----
> .../net/ethernet/mellanox/mlx5/core/en_main.c | 2 --
> .../net/ethernet/mellanox/mlx5/core/en_rep.c | 2 --
> .../ethernet/netronome/nfp/nfp_net_common.c | 2 --
> drivers/net/ethernet/qlogic/qede/qede_main.c | 6 -----
> .../net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 --
> drivers/net/ethernet/sfc/efx.c | 2 --
> drivers/net/geneve.c | 14 ++++-------
> drivers/net/netdevsim/netdev.c | 2 --
> drivers/net/vxlan.c | 15 ++++--------
> include/linux/netdevice.h | 17 -------------
> include/net/udp_tunnel.h | 8 +++++++
> net/core/dev.c | 2 +-
> net/ipv4/udp_tunnel_core.c | 24 ++++---------------
> 26 files changed, 22 insertions(+), 106 deletions(-)
>
next prev parent reply other threads:[~2021-01-07 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 21:06 [PATCH net-next 0/4] udp_tunnel_nic: post conversion cleanup Jakub Kicinski
2021-01-06 21:06 ` [PATCH net-next 1/4] udp_tunnel: hard-wire NDOs to udp_tunnel_nic_*_port() helpers Jakub Kicinski
2021-01-06 21:06 ` [PATCH net-next 2/4] udp_tunnel: remove REGISTER/UNREGISTER handling from tunnel drivers Jakub Kicinski
2021-01-06 21:06 ` [PATCH net-next 3/4] net: remove ndo_udp_tunnel_* callbacks Jakub Kicinski
2021-01-06 21:06 ` [PATCH net-next 4/4] udp_tunnel: reshuffle NETIF_F_RX_UDP_TUNNEL_PORT checks Jakub Kicinski
2021-01-06 21:53 ` [PATCH net-next 0/4] udp_tunnel_nic: post conversion cleanup Alexander Duyck
2021-01-07 18:44 ` Jacob Keller [this message]
2021-01-07 22:34 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea428429-eb5f-166c-1773-acc7aa824731@intel.com \
--to=jacob.e.keller@intel.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=alexander.duyck@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@netronome.com \
--cc=tariqt@nvidia.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).