From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AACD2E11B6 for ; Thu, 21 Aug 2025 09:14:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755767685; cv=none; b=QgAQWnWieXKREEOPKwB5u8zpsnNNoZGdmbciPJx+xVx6PCV7mZyq+l4qeAjB71vechbxON3CijoPgsEz+aCqrQacgcVTEnXh7S8ymhhq6k0+LoeAJCAbnALX19kEA9E8Q9+qsTj9WiOxmtyKbzQ3WMVQpCcuOOrINDBMXrLnUzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755767685; c=relaxed/simple; bh=1ewMSBBg9cmq1Asjak1aE7nAcBgixBHay9BTXHvKZ8g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OtFmdb/XTFuqCR1m6sBM/RaIDWNXEEL1nZ7ChcpuyQfkZLrhRFNgBwTDAAOjn0qJGvdKJET+2ppAyhgz5jaMauziWEHgvJEplswehmwEv83bs/JUgP+N+geLLtXYaflfTXFgVMbmFuh1+zmhGLtqoHfoJvVe6z+ueYisnY3innI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TPmTz98N; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TPmTz98N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755767682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d/cls12ySWE3NAa48m4sMHEPJFNdbq2Fp43VAzgYuEY=; b=TPmTz98NyWIBT4cp0ZJBrTe/4chifDMw8jb1Sa4djuLZ5/waJb+/Kf8Q29VojSkQsazdn6 wTJNpCE21iZFNxAbx4C5ZxoIMCACSFfe14QQ/CQ07pi7kNr+GFNOvz70I8wtDzhHU7flqj h4TrisJlEr4BMNMFZQ7cSjXjtmMtmdo= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-mwiMw37WPYSD5Tpbn_Qh7A-1; Thu, 21 Aug 2025 05:14:40 -0400 X-MC-Unique: mwiMw37WPYSD5Tpbn_Qh7A-1 X-Mimecast-MFC-AGG-ID: mwiMw37WPYSD5Tpbn_Qh7A_1755767680 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7e870316b85so163652985a.0 for ; Thu, 21 Aug 2025 02:14:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755767680; x=1756372480; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d/cls12ySWE3NAa48m4sMHEPJFNdbq2Fp43VAzgYuEY=; b=pwPjPxXhJ7/S28si8PQxOybIg+dFtzH0W5B8PtC8rhDGzoX3FcOiA3Kgs82oSbcoVe k+a8/sJr6D++KjGM0N8685McuwaKKcY1rRFNAUWsPsQyU5WjFiM9b74Fp6ZxHn8Z2TT3 Pywh9GQv5bo19aU/ZY1PdILteFWNvBslwxi121nCXTHXqlg864x/iW9qa8EXk1AXekws iquPAC9bdn2UYjE1UOGH57W/bfMucAy/ylRHNhUEJZAg2GWShUNQINfshLFyCrVqg8s5 iuukGhGpSrqn6UQUtlkQxxAcvPrHsKKkan8R1Qo17l8wczWUU+XoIRxS5WXocK29jH1A MtSg== X-Forwarded-Encrypted: i=1; AJvYcCX6VIL9kuQNFBk4D9p0WlMuvz6qO79/O+k6a6r+CD7WX3gk2a5hskUjw9uqo6L/Ksq3AveFJK0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqv34L8Kr+grS3FjM6KSL+Ny6lMOqvPQJq36QJ3/XgIGTT9wxM tGPInsPOqPNBDYRAumftNZQLCKlrw0ipFKlLBYi9yAdYTTq19axtHqPbch6yZ8Dod6/O2MAPCjg YuIl/cTkwACcktNhYnxmJm/dzba+b2Dtz5goQD6Lvr5nZ30ZXozpIXm+dCn0DEFxyHw== X-Gm-Gg: ASbGncscarJ+1U/pU53F9//fksXomvsH4k6P7bqGfADkqU1dqww4nePf6OUVxtKG4EN GjNXe9rwNHh+X+6mjEFKu5s3QsYAOklGDIHpcgnCC0+eix7f0rBdM6bYNSu+t+/aHJzuqC87Xvt c8RhZgL9/7PpuFnv6oGV8OZ4O2IM/339f1HOmkI71KKlRMrLiNk1InBzSMxAlHaIerRkfHGKC4l Jh7I5pdbjDXL8DS21cs1bh1G4GRBQjpnkStaXER/f8Z93mRzGyIWr6s32v2Uli15D9EKL9Km94y BObBCVKhpV5ueWb6yjWIKzffviYb/ZKIY6z8bpgFkmPMdLrfzFUh6S/X89oj1sFHwRN6ixiT9/M vDjDoNXl3SGA= X-Received: by 2002:a05:620a:31a9:b0:7e8:7eee:7d66 with SMTP id af79cd13be357-7ea08e3ecedmr181780385a.40.1755767679868; Thu, 21 Aug 2025 02:14:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZ0c/CeAt2mU1zijFZ8Xtf8yg68lytCTDkdCZS7E9eYRtoLIMsMFMlh4Pv2bSyDJHFqzlT3w== X-Received: by 2002:a05:620a:31a9:b0:7e8:7eee:7d66 with SMTP id af79cd13be357-7ea08e3ecedmr181778085a.40.1755767679305; Thu, 21 Aug 2025 02:14:39 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e87e04abd8sm1085524985a.18.2025.08.21.02.14.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 02:14:38 -0700 (PDT) Message-ID: Date: Thu, 21 Aug 2025 11:14:34 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3 net-next 3/3] selftests: bonding: add test for LACP actor port priority To: Hangbin Liu , netdev@vger.kernel.org Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Nikolay Aleksandrov , Simon Horman , Shuah Khan , Jonathan Corbet , Petr Machata , Amit Cohen , Vladimir Oltean , Stephen Hemminger , David Ahern , Jonas Gorski , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20250818092311.383181-1-liuhangbin@gmail.com> <20250818092311.383181-4-liuhangbin@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250818092311.383181-4-liuhangbin@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/18/25 11:23 AM, Hangbin Liu wrote: > +# Trigger link state change to reselect the aggregator > +ip -n "${c_ns}" link set eth1 down > +sleep 1 > +ip -n "${c_ns}" link set eth1 up > +# the active agg should be connect to switch > +bond_agg_id=$(cmd_jq "ip -n ${c_ns} -d -j link show bond0" ".[].linkinfo.info_data.ad_info.aggregator") > +eth0_agg_id=$(cmd_jq "ip -n ${c_ns} -d -j link show eth0" ".[].linkinfo.info_slave_data.ad_aggregator_id") > +[ "${bond_agg_id}" -ne "${eth0_agg_id}" ] && RET=1 A few lines above exceed 100 chars, it would be better to wrap them > +log_test "bond 802.3ad" "actor_port_prio select" > + > +# Change the actor port prio and re-test > +ip -n "${c_ns}" link set eth0 type bond_slave actor_port_prio 10 > +ip -n "${c_ns}" link set eth2 type bond_slave actor_port_prio 1000 > +# Trigger link state change to reselect the aggregator > +ip -n "${c_ns}" link set eth1 down > +sleep 1 > +ip -n "${c_ns}" link set eth1 up > +# now the active agg should be connect to backup switch > +bond_agg_id=$(cmd_jq "ip -n ${c_ns} -d -j link show bond0" ".[].linkinfo.info_data.ad_info.aggregator") > +eth2_agg_id=$(cmd_jq "ip -n ${c_ns} -d -j link show eth2" ".[].linkinfo.info_slave_data.ad_aggregator_id") > +# shellcheck disable=SC2034 > +if [ "${bond_agg_id}" -ne "${eth2_agg_id}" ]; then > + RET=1 > +fi > +log_test "bond 802.3ad" "actor_port_prio switch" The test above is basically the same of the previous one, with a slightly different style, it would be better to factor the whole status cycling, data fetching and comparison in an helper to avoid code duplication and the mentioned confusing difference. Thanks, Paolo