From: Martin KaFai Lau <martin.lau@linux.dev>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, saeedm@nvidia.com, leon@kernel.org,
shayagr@amazon.com, akiyano@amazon.com, darinzon@amazon.com,
sgoutham@marvell.com, lorenzo.bianconi@redhat.com,
toke@redhat.com, teknoraver@meta.com, ttoukan.linux@gmail.com
Subject: Re: [PATCH net v2 6/8] veth: take into account device reconfiguration for xdp_features flag
Date: Wed, 5 Apr 2023 17:56:45 -0700 [thread overview]
Message-ID: <ea5cda51-e8f0-2bcd-abfa-b6bf4b11d354@linux.dev> (raw)
In-Reply-To: <f20cfdb08d7357b0853d25be3b34ace4408693be.1678364613.git.lorenzo@kernel.org>
On 3/9/23 4:25 AM, Lorenzo Bianconi wrote:
> +static void veth_set_xdp_features(struct net_device *dev)
> +{
> + struct veth_priv *priv = netdev_priv(dev);
> + struct net_device *peer;
> +
> + peer = rcu_dereference(priv->peer);
> + if (peer && peer->real_num_tx_queues <= dev->real_num_rx_queues) {
> + xdp_features_t val = NETDEV_XDP_ACT_BASIC |
> + NETDEV_XDP_ACT_REDIRECT |
> + NETDEV_XDP_ACT_RX_SG;
> +
> + if (priv->_xdp_prog || veth_gro_requested(dev))
> + val |= NETDEV_XDP_ACT_NDO_XMIT |
> + NETDEV_XDP_ACT_NDO_XMIT_SG;
This broke the xdp_do_redirect selftest. The bpf CI is consistently failing at:
test_xdp_do_redirect:FAIL:veth_src query_opts.feature_flags unexpected veth_src
query_opts.feature_flags: actual 35 != expected 103
Please address it asap.
next prev parent reply other threads:[~2023-04-06 0:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:25 [PATCH net v2 0/8] update xdp_features flag according to NIC re-configuration Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 1/8] tools: ynl: fix render-max for flags definition Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 2/8] tools: ynl: fix get_mask utility routine Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 3/8] xdp: add xdp_set_features_flag " Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 4/8] net: thunderx: take into account xdp_features setting tx/rx queues Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 5/8] net: ena: " Lorenzo Bianconi
2023-03-09 12:25 ` [PATCH net v2 6/8] veth: take into account device reconfiguration for xdp_features flag Lorenzo Bianconi
2023-03-13 14:15 ` Matthieu Baerts
2023-03-13 15:50 ` Eric Dumazet
2023-03-13 15:53 ` Eric Dumazet
2023-03-13 16:31 ` Matthieu Baerts
2023-03-13 16:35 ` Lorenzo Bianconi
2023-03-13 16:37 ` Eric Dumazet
2023-03-13 16:47 ` Lorenzo Bianconi
2023-04-06 0:56 ` Martin KaFai Lau [this message]
2023-03-09 12:25 ` [PATCH net v2 7/8] net/mlx5e: " Lorenzo Bianconi
2023-03-15 23:39 ` Jakub Kicinski
2023-03-16 0:29 ` Jakub Kicinski
2023-03-16 2:46 ` Saeed Mahameed
2023-03-16 2:53 ` Jakub Kicinski
2023-03-16 5:03 ` Saeed Mahameed
2023-03-16 5:37 ` Jakub Kicinski
2023-03-09 12:25 ` [PATCH net v2 8/8] mvpp2: take care of xdp_features when reconfiguring queues Lorenzo Bianconi
2023-03-11 5:50 ` [PATCH net v2 0/8] update xdp_features flag according to NIC re-configuration patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea5cda51-e8f0-2bcd-abfa-b6bf4b11d354@linux.dev \
--to=martin.lau@linux.dev \
--cc=akiyano@amazon.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sgoutham@marvell.com \
--cc=shayagr@amazon.com \
--cc=teknoraver@meta.com \
--cc=toke@redhat.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).