From: Florian Fainelli <f.fainelli@gmail.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH net-next v2 2/2] net: stmmac: Fixup the tail addr setting in xmit path
Date: Mon, 10 Sep 2018 11:46:43 -0700 [thread overview]
Message-ID: <ea85407f-c1b3-4070-fd8b-bca55cb1962c@gmail.com> (raw)
In-Reply-To: <2b430bedf98176f052e1530004ab623d26d2c71a.1536570319.git.joabreu@synopsys.com>
On 09/10/2018 02:14 AM, Jose Abreu wrote:
> Currently we are always setting the tail address of descriptor list to
> the end of the pre-allocated list.
>
> According to databook this is not correct. Tail address should point to
> the last available descriptor + 1, which means we have to update the
> tail address everytime we call the xmit function.
>
> This should make no impact in older versions of MAC but in newer
> versions there are some DMA features which allows the IP to fetch
> descriptors in advance and in a non sequential order so its critical
> that we set the tail address correctly.
Can you include the appropriate Fixes tag here so this can easily be
backported to relevant stable branches?
--
Florian
next prev parent reply other threads:[~2018-09-10 23:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 9:14 [PATCH net-next v2 0/2] net: stmmac: Coalesce and tail addr fixes Jose Abreu
2018-09-10 9:14 ` [PATCH net-next v2 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races Jose Abreu
2018-09-10 11:43 ` [net-next, v2, " Neil Armstrong
2018-09-10 12:52 ` Jose Abreu
2018-09-10 12:55 ` Jose Abreu
2018-09-10 13:46 ` Neil Armstrong
2018-09-10 14:44 ` Jose Abreu
2018-09-10 15:49 ` Neil Armstrong
2018-09-10 16:21 ` Jose Abreu
2018-09-10 18:15 ` Neil Armstrong
2018-09-11 8:17 ` Jose Abreu
2018-09-12 13:50 ` Neil Armstrong
2018-09-12 14:25 ` Jose Abreu
2018-09-10 19:22 ` [PATCH net-next v2 " Florian Fainelli
2018-09-12 14:23 ` Jose Abreu
2018-09-18 7:02 ` Tal Gilboa
2018-09-10 9:14 ` [PATCH net-next v2 2/2] net: stmmac: Fixup the tail addr setting in xmit path Jose Abreu
2018-09-10 18:46 ` Florian Fainelli [this message]
2018-09-12 14:17 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea85407f-c1b3-4070-fd8b-bca55cb1962c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).