From: Tim Mattox <tmattox@gmail.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH] forcedeth: jumbo frame support
Date: Sat, 16 Jul 2005 17:09:09 -0400 [thread overview]
Message-ID: <ea86ce22050716140987d7ef8@mail.gmail.com> (raw)
In-Reply-To: <42D94E95.1060303@colorfullife.com>
This is just from a simple read of Manfred's patch, but shouldn't one side of
the if-else use the NV_PKTLIMIT_2 value? If not, why is
np->pkt_limit = NV_PKTLIMIT_1; inside the if-else at all?
On 7/16/05, Manfred Spraul <manfred@colorfullife.com> wrote:
[snip]
> +/* maximum mtu size */
> +#define NV_PKTLIMIT_1 ETH_DATA_LEN /* hard limit not known */
> +#define NV_PKTLIMIT_2 9100 /* Actual limit according to NVidia: 9202 */
[snip]
> @@ -2007,13 +2093,16 @@
>
> /* handle different descriptor versions */
> if (pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_1 ||
> - pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_2 ||
> - pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_3 ||
> - pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_12 ||
> - pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_13)
> + pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_2 ||
> + pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_3 ||
> + pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_12 ||
> + pci_dev->device == PCI_DEVICE_ID_NVIDIA_NVENET_13) {
> np->desc_ver = DESC_VER_1;
> - else
> + np->pkt_limit = NV_PKTLIMIT_1;
> + } else {
> np->desc_ver = DESC_VER_2;
> + np->pkt_limit = NV_PKTLIMIT_1;
> + }
--
Tim Mattox - tmattox@gmail.com
http://homepage.mac.com/tmattox/
I'm a bright... http://www.the-brights.net/
next prev parent reply other threads:[~2005-07-16 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-16 18:14 [PATCH] forcedeth: jumbo frame support Manfred Spraul
2005-07-16 21:09 ` Tim Mattox [this message]
2005-07-16 21:15 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea86ce22050716140987d7ef8@mail.gmail.com \
--to=tmattox@gmail.com \
--cc=jgarzik@pobox.com \
--cc=manfred@colorfullife.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).