From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ADD53B6377 for ; Fri, 20 Mar 2026 13:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774012861; cv=none; b=OYIiRDbj5dODU2jN2XQsTEcmZamkhcp6ozb0Qk17DJ5KXMYI0lwTJbbTuw3Ay1A7GgHueyF/V+QCo0LFMIC8kcy8Iem1+cOGbiUe1JHnfpN6JKctYou/MrcgSWkGegtPSpKRupKwMKlBI1Ws8aDPtN1Q6so8d+4mSnrEMk/FQMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774012861; c=relaxed/simple; bh=PQ6yOqa4PgyAZF4ktQrGNLVKtsw3530HSr+f7H4rcpw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GykQg/J38yuxbnFCxq5mRliYrmVIXqHvZqeXf30F678f9tgECcuE5UyE0Yky3KR0vMigzy0dYFbUFHSLPRVutu14YuikN/35vPouWzD2/15+BJlgloT5Ruz3fmWayvTOUE3XV+frTgw8KymaGMD8O0kRp3jEwmv0Z8+qhK6xeS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WxXay1q4; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WxXay1q4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774012856; x=1805548856; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PQ6yOqa4PgyAZF4ktQrGNLVKtsw3530HSr+f7H4rcpw=; b=WxXay1q4zo8CXb3SExwCGpGGy2pB7crV9fJsitRsNHGNdAyBnTDUkDaV oGLzZ00HN6QAxh85EOQjpnMFOYgHtLx+oPopM0YLLj6QmLZZBs+02FD+e B/B1Nt0LhoBaD5SdlGHzMejUwFIajYCL4r31br1ZxetjWYbYfFwg5kW0M bQJSI6Ig+TfNAGoHPU5JcfmTdL3cwfLsHyjBWRCTALsWw/2vCpBq97zAg aSIsjnJ82ozl8CdxrrkUJ8vp0M3dbO5jSyb7mA7+bt+vpClwQLSyDcd4v TD/AAayFT/Ioce0pjLEsWiOo5ixIf08JBNUqtyRfFjzOMQRVljvA9ynpE g==; X-CSE-ConnectionGUID: W54jYpMFSciCZ+Q7L9/igA== X-CSE-MsgGUID: Cg8JVK5fT7OSxq/iGKuSpQ== X-IronPort-AV: E=McAfee;i="6800,10657,11735"; a="85722706" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="85722706" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 06:20:55 -0700 X-CSE-ConnectionGUID: YB/3+kZyQZOx90BORRLQcQ== X-CSE-MsgGUID: 02YQOKTsRDmxZwYCT/OZ+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="227409603" Received: from mszycik-mobl1.ger.corp.intel.com (HELO [10.246.17.139]) ([10.246.17.139]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 06:20:53 -0700 Message-ID: Date: Fri, 20 Mar 2026 14:20:51 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: fix allocating excessive memory in ice_create_lag_recipe() To: Aleksandr Loktionov , intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com Cc: netdev@vger.kernel.org, Marcin Szycik References: <20260320050529.422444-1-aleksandr.loktionov@intel.com> Content-Language: en-US From: Marcin Szycik In-Reply-To: <20260320050529.422444-1-aleksandr.loktionov@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20.03.2026 06:05, Aleksandr Loktionov wrote: > From: Marcin Szycik ACK > For some reason ice_create_lag_recipe() allocates an array of 64 > struct ice_aqc_recipe_data_elem elements, while it only needs one (1). > Fix it, while also using kzalloc_obj(). > > Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface") > Signed-off-by: Marcin Szycik > Signed-off-by: Aleksandr Loktionov > --- > drivers/net/ethernet/intel/ice/ice_lag.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_lag.c b/drivers/net/ethernet/intel/ice/ice_lag.c > index 310e8fe..70357dc 100644 > --- a/drivers/net/ethernet/intel/ice/ice_lag.c > +++ b/drivers/net/ethernet/intel/ice/ice_lag.c > @@ -2418,8 +2418,8 @@ static int ice_create_lag_recipe(struct ice_hw *hw, u16 *rid, > if (err) > return err; > > - new_rcp = kzalloc(ICE_RECIPE_LEN * ICE_MAX_NUM_RECIPES, GFP_KERNEL); > + new_rcp = kzalloc_obj(*new_rcp, GFP_KERNEL); > if (!new_rcp) > return -ENOMEM; > > memcpy(new_rcp, base_recipe, ICE_RECIPE_LEN); >