From: David Ahern <dsahern@gmail.com>
To: Donald Sharp <sharpd@cumulusnetworks.com>,
netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH iproute2] ip: mroute: Add table output to show command
Date: Wed, 14 Jun 2017 09:42:11 -0600 [thread overview]
Message-ID: <eab71694-2e6e-65f8-62df-b68e76a13cff@gmail.com> (raw)
In-Reply-To: <1497442092-14252-1-git-send-email-sharpd@cumulusnetworks.com>
On 6/14/17 6:08 AM, Donald Sharp wrote:
> diff --git a/ip/ipmroute.c b/ip/ipmroute.c
> index 4d2d758..70f4c4f 100644
> --- a/ip/ipmroute.c
> +++ b/ip/ipmroute.c
> @@ -189,6 +189,11 @@ int print_mroute(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
> fprintf(fp, ", Age %4i.%.2i", (int)tv.tv_sec,
> (int)tv.tv_usec/10000);
> }
> +
> + if (table && (table != RT_TABLE_MAIN || show_details > 0) && !filter.tb)
> + fprintf(fp, " Table: %s",
I suggest lowercase 'table' to be consistent with ip route output.
> + rtnl_rttable_n2a(table, b1, sizeof(b1)));
> +
> fprintf(fp, "\n");
> fflush(fp);
> return 0;
> --
next prev parent reply other threads:[~2017-06-14 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 12:08 [PATCH iproute2] ip: mroute: Add table output to show command Donald Sharp
2017-06-14 12:53 ` Nikolay Aleksandrov
2017-06-14 15:42 ` David Ahern [this message]
2017-06-14 15:44 ` Nikolay Aleksandrov
2017-06-14 15:47 ` David Ahern
2017-06-14 20:32 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eab71694-2e6e-65f8-62df-b68e76a13cff@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sharpd@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).