From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11B0A15B135 for ; Tue, 14 Oct 2025 12:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760446174; cv=none; b=fM8CYJeR5gHGsvRtG2IJpjt1TY3PgqL2DzaGlOdlyBmh6LNkJBf5XOuHfBRJa2F5nNK8+LuRiPqp9gY6dqUDgVhKC7JglmoZ0Y+htYJ4U8PdkigGLuVL77ea7pb+TZkEEPa1+AbKY43J7moh+3LMOTGSgI6t8Or9tT8CJetwcQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760446174; c=relaxed/simple; bh=v6U7DLGCjYxoj5ENGgqW08NtBhbBHu0yt05+ofF8WwA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TaHipoGpVDejxzX9aI/TdONCR4J23FbkNcA/JCmjkRQ3gyujeSod+ELOn7czVfNvzWFn5NXfw6VC6OSYgwIsbQfmR7n/xmdPuFrZco1JRJExKJ6TmV1RX3V4AISxhP5RWbyyoKmUouI3Y9QhKsoeYeI1x7O5eT4vkEV5Xl/I7nk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gtSc4LB7; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gtSc4LB7" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-46e34bd8eb2so53976345e9.3 for ; Tue, 14 Oct 2025 05:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760446171; x=1761050971; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0xSNdK/UPhiag6fJGs/Gpb+fa/gGbLtGUzql412YrQM=; b=gtSc4LB7OA7bRkzqTj38aPPkoYheXqePmcWvS0BDT7u3+FjqbaVOnCg0bQgDzuWVDX i4xiwLOO8eaiJt4ApuZwEvYB4CW/QGH6CAj3ySVxgGUc7PV03bgXViF20i75GGUMZrgR 6ssv7ZYr26cbCr8IgsfIbRNEA+dTAv/e9m3kHbPwamAhXFrIjfcdYO/bSiq6OCpGZr+5 YmaEEt6ywKIA8U/pTMbEUHPG+NqHITas0i6Q0sNYAR47Z918J4SzCvMgSLuw2hME1HCn 5zhQIuN0eSSfrlJQz3Dceg3VDf4MffJYdfsMUB2HjejhcSOSKbtRU1eNs0mS1VobWXLg BccA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760446171; x=1761050971; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0xSNdK/UPhiag6fJGs/Gpb+fa/gGbLtGUzql412YrQM=; b=EylYzCdICKaAArJ5vRDhIlbwHl34qasxll46M54XunnImOzitbQf8m4zDs5gPxlI8V b8UQLXLP+7TRj4iP5so6WR7jNuV7OvndfBHM+ADEzc8FGIKChm1wA5TWcAkvZeP8BD6O gt2e6boKwsUnRVSVtO5209dYCwuf6p2T4wHs43cFoOvn7Zr53qn6mpyGieiEbKNRLPpn juOnzqAjPHW9uxtCvEcXLFBNENYyMS3swyBH/Gt7ku+hbCgu+tuLJpyOhkX//uuEiauN ZTBTzhBH2c0jPItd4UpGMnLGZMBNjGw6pmGm24gIpBdleZvQZl1j8uDviAPCTMyY+a6F pnEg== X-Gm-Message-State: AOJu0YxApoe8im71a34No4081bd0HsUjkEixiSuhy5ht62oSDgRdIInD mM10U/w4R9GujkxSCIL3agyb6cFmKtbJF0eAYv/pEr8PX4yMVbzA714G X-Gm-Gg: ASbGncs1yZ25qXumy8LknXGsnh8u4Vt9+bJse5PQkrytWeGUJFaqPjzoaZmDDwIaMBU uOaGdQQUXpGqkyssoX4vhfNPPX8Nm8K7tC4IkGCUPNWO8B9ckJUyTZCOb8AkJwxXtrzHnPO9nPQ DBqhd9XLqJivajQIMkp+rJ84bBcFtndvVP52gICxDZoefnu1u/r3bwo0jBcEYSu2F4QwM8WA/AJ 67ytrYIEO5nPCL4J+5DtmZIm+Lmuez9bRyp8kzYCH1/E+KnvwjUGd+DycSsKDblfbnhrCc57XiV OmCYrsRdW16C7uIPyk3ts4LqodU68jlhwXf9pbtLdPCmbvoDOJRtoRxAowPDHMvh7hwO2pW1xG/ UBK67TbfFn1Mz6eMb9z8oe3CKGrl4F+7Ao0YWg4p4hrRXLOBnZVIzn/yqkzZP0lyRM34le3kk/G K3Haqg3RkQuUA3UYkBZ0o= X-Google-Smtp-Source: AGHT+IGoUGOOarSp00OMRYWhOXW34mYrkF25elYJu4oLZtBIvtZyX2JSTRSEbwHePA1SLut/vaU6wQ== X-Received: by 2002:a05:600c:c091:b0:46e:59bd:f7d3 with SMTP id 5b1f17b1804b1-46fae33dffamr97594825e9.20.1760446171042; Tue, 14 Oct 2025 05:49:31 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:77fd:1068:74c8:af87? ([2620:10d:c092:600::1:7ec0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb489194dsm238775265e9.12.2025.10.14.05.49.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Oct 2025 05:49:29 -0700 (PDT) Message-ID: Date: Tue, 14 Oct 2025 13:50:45 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 00/24][pull request] Queue configs and large buffer providers To: Mina Almasry , Jakub Kicinski Cc: netdev@vger.kernel.org, Andrew Lunn , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Simon Horman , Donald Hunter , Michael Chan , Pavan Chebbi , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Joshua Washington , Harshitha Ramamurthy , Jian Shen , Salil Mehta , Jijie Shao , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Bharat Bhushan , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Ilias Apalodimas , Joe Damato , David Wei , Willem de Bruijn , Breno Leitao , Dragos Tatulea , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-rdma@vger.kernel.org, Jonathan Corbet References: <20251013105446.3efcb1b3@kernel.org> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/14/25 05:41, Mina Almasry wrote: > On Mon, Oct 13, 2025 at 10:54 AM Jakub Kicinski wrote: >> >> On Mon, 13 Oct 2025 15:54:02 +0100 Pavel Begunkov wrote: >>> Jakub Kicinski (20): >>> docs: ethtool: document that rx_buf_len must control payload lengths >>> net: ethtool: report max value for rx-buf-len >>> net: use zero value to restore rx_buf_len to default >>> net: clarify the meaning of netdev_config members >>> net: add rx_buf_len to netdev config >>> eth: bnxt: read the page size from the adapter struct >>> eth: bnxt: set page pool page order based on rx_page_size >>> eth: bnxt: support setting size of agg buffers via ethtool >>> net: move netdev_config manipulation to dedicated helpers >>> net: reduce indent of struct netdev_queue_mgmt_ops members >>> net: allocate per-queue config structs and pass them thru the queue >>> API >>> net: pass extack to netdev_rx_queue_restart() >>> net: add queue config validation callback >>> eth: bnxt: always set the queue mgmt ops >>> eth: bnxt: store the rx buf size per queue >>> eth: bnxt: adjust the fill level of agg queues with larger buffers >>> netdev: add support for setting rx-buf-len per queue >>> net: wipe the setting of deactived queues >>> eth: bnxt: use queue op config validate >>> eth: bnxt: support per queue configuration of rx-buf-len >> >> I'd like to rework these a little bit. >> On reflection I don't like the single size control. >> Please hold off. >> > > FWIW when I last looked at this I didn't like that the size control > seemed to control the size of the allocations made from the pp, but > not the size actually posted to the NIC. > > I.e. in the scenario where the driver fragments each pp buffer into 2, > and the user asks for 8K rx-buf-len, the size actually posted to the > NIC would have actually been 4K (8K / 2 for 2 fragments). > > Not sure how much of a concern this really is. I thought it would be > great if somehow rx-buf-len controlled the buffer sizes actually > posted to the NIC, because that what ultimately matters, no (it ends > up being the size of the incoming frags)? Or does that not matter for > some reason I'm missing? Maybe we should just make a rule that if hardware doesn't support the given size, qops should fail, but ultimately the userspace should be able to handle it either way as gro is packing not 100% reliably. -- Pavel Begunkov