From: Florian Fainelli <f.fainelli@gmail.com>
To: hongbo.wang@nxp.com, xiaoliang.yang_1@nxp.com,
allan.nielsen@microchip.com, po.liu@nxp.com,
claudiu.manoil@nxp.com, alexandru.marginean@nxp.com,
vladimir.oltean@nxp.com, leoyang.li@nxp.com, mingkai.hu@nxp.com,
andrew@lunn.ch, vivien.didelot@gmail.com, davem@davemloft.net,
jiri@resnulli.us, idosch@idosch.org, kuba@kernel.org,
vinicius.gomes@intel.com, nikolay@cumulusnetworks.com,
roopa@cumulusnetworks.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, horatiu.vultur@microchip.com,
alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
linux-devel@linux.nxdi.nxp.com
Subject: Re: [PATCH] net: dsa: Add protocol support for 802.1AD when adding or deleting vlan for dsa switch and port
Date: Tue, 21 Jul 2020 10:55:17 -0700 [thread overview]
Message-ID: <eaf6e25a-4e64-1ffe-972a-9d309d307294@gmail.com> (raw)
In-Reply-To: <20200721110214.15268-1-hongbo.wang@nxp.com>
On 7/21/20 4:02 AM, hongbo.wang@nxp.com wrote:
> From: "hongbo.wang" <hongbo.wang@nxp.com>
>
> the following command will be supported:
> Add VLAN:
> ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100
> Delete VLAN:
> ip link del link swp1 name swp1.100
>
> when adding vlan, this patch only set protocol for user port,
> cpu port don't care it, so set parameter proto to 0 for cpu port.
My previous feedback has been partially addressed, can you also post the
switch driver changes that are going to implement the driver side
changes? Presumably you must act on the 802.1AD programming request in
the switch driver somehow, right?
--
Florian
next prev parent reply other threads:[~2020-07-21 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 11:02 [PATCH] net: dsa: Add protocol support for 802.1AD when adding or deleting vlan for dsa switch and port hongbo.wang
2020-07-21 17:55 ` Florian Fainelli [this message]
2020-07-22 5:51 ` [EXT] " Hongbo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf6e25a-4e64-1ffe-972a-9d309d307294@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.marginean@nxp.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=hongbo.wang@nxp.com \
--cc=horatiu.vultur@microchip.com \
--cc=idosch@idosch.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-devel@linux.nxdi.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingkai.hu@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=po.liu@nxp.com \
--cc=roopa@cumulusnetworks.com \
--cc=vinicius.gomes@intel.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).