From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification Date: Wed, 14 Feb 2018 13:10:19 -0800 Message-ID: References: <331448b2-65d1-0f62-033c-b97d87a57b87@oracle.com> <20180214190110.GM11528@oracle.com> <20180214.140256.2107383260203156183.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: sowmini.varadhan@oracle.com, netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com, rds-devel@oss.oracle.com To: David Miller Return-path: Received: from aserp2120.oracle.com ([141.146.126.78]:45766 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030501AbeBNVK3 (ORCPT ); Wed, 14 Feb 2018 16:10:29 -0500 In-Reply-To: <20180214.140256.2107383260203156183.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2/14/2018 11:02 AM, David Miller wrote: > From: Sowmini Varadhan > Date: Wed, 14 Feb 2018 14:01:10 -0500 > >> On (02/14/18 10:50), Santosh Shilimkar wrote: >>> generic comment and please update it where it is applicable >>> in terms of variable names, notifiers etc. >>> >>> RDS support true zero copy already with RDMA transport so some of >>> this code can easily get confused. >>> >>> So I suggest something like below. >>> s/zerocopy/zeromsgcopy >>> s/zcopy/zmsgcopy >>> s/zcookie/zmsgcpycookie >>> s/znotifier/zmsgcpynotifier >> >> I'd like to hear some additional opinions from the list on this: >> the existing socket API for TCP etc. already uses ZEROCOPY, and other >> than extending variable names (and putting me at risk of violating the >> "fit within 80 chars per line" requirement, leading to not-so-pretty >> line wraps), I'm not seeing much value in this. > > I agree, this name change requires seems pointless. Just keep the names > the way they are, thank you. > Dave I understand your point for generic code and I was not all asking to rename anything in generic code. My point was new code getting added to RDS to support this zero copy message option. Within RDS, core code is common and all the infrastructure with it and it will be hard to follow the code if that distinction is not maintained. Ofcourse you have a last say on this list so if you want to over rule the comment, I will step back :-) Regards, Santosh