From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FE1C10F0B for ; Wed, 3 Apr 2019 21:15:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4461B206B8 for ; Wed, 3 Apr 2019 21:15:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tjPQi1Co" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbfDCVPc (ORCPT ); Wed, 3 Apr 2019 17:15:32 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37477 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbfDCVPb (ORCPT ); Wed, 3 Apr 2019 17:15:31 -0400 Received: by mail-wr1-f68.google.com with SMTP id w10so724257wrm.4 for ; Wed, 03 Apr 2019 14:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YITLNzD5A5EnXYq0eDKp9zEFOWrm+fv0cezUHCBxMb0=; b=tjPQi1CoFX7jrNzoCghGp7J5Bi4lXJrxp4ZuzQewuCP+AXGJjlOhWR+Rk4i4gYW6f1 6CsZxICNMP7cUZeLdyCaOLhlQrXOMxRe8Z6Sr/0pN2/+dKIAhf5dNW7+25UkplN55Zf5 8Z/KfXemgLP4V5hXomLNAOoMt++51v9EmN/O1oM74w58MXHxCvgB5tky3gRj1ijXCtJy R8t1TdlikR2Lvn/gxNtBSkEr7ZoC5Cu/Rg9NtPS+6RdEBTOxv/3vPM+fffFWRRd0NJES FKfKk9sHqlcy/8+nsvjLm+fUnT3miL1UK1DOdWwR92DqdXA2TfE6VqKQ0IUYRFe4Uxom i8YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YITLNzD5A5EnXYq0eDKp9zEFOWrm+fv0cezUHCBxMb0=; b=hb87JD5z1HL6VkUhR5sX+jf1NBLYI81honWOARHkovwFi0/3+AC3IQzde3dURdKHgA IUY7xcgFNPQO8t9XNvKX428AamOZe/cTWBnMwJz+1PXnc6M43OKbK4uqLqSKGqFwt94J oFluF4239xyG4aXX0OpSGqIl3arc8is18lvzOl/NT/L8m9dei+ziEaSfu63/+2aVLlKT iWv69PSxRwWO3PG4/HShQpL6eghxjo3QfF4Pupja43c50tuZ0DeiFESqNr/1lsJ4OShM 7pYL0op168KnLKk8ELUoqzG/8XAUyXZh5VIiw2lQp4s6CUG4pXcGToo5mPSt8K6ij1vG vg5A== X-Gm-Message-State: APjAAAW60BehMrDtr9unZvhd0KlzAVkLNFyfzRho67V4pPQHA8xzKmW2 rAOvGcHKsy+6UuabTHFjHFS59rdf X-Google-Smtp-Source: APXvYqxqxNMeiw9VlRmVx9olHuZYXHM+0AFsAegNQsy9Nu8pxx3AtR45zCujcQmHotxPk0LTVR9GaA== X-Received: by 2002:adf:dc83:: with SMTP id r3mr1143323wrj.179.1554326129160; Wed, 03 Apr 2019 14:15:29 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:ed2b:516:5ae8:487f? (p200300EA8BE1DD00ED2B05165AE8487F.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:ed2b:516:5ae8:487f]) by smtp.googlemail.com with ESMTPSA id a187sm50059wma.32.2019.04.03.14.15.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 14:15:28 -0700 (PDT) Subject: [PATCH net-next v2 2/2] net: phy: realtek: remove setting callback get_features and use phylib fallback From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: Message-ID: Date: Wed, 3 Apr 2019 23:15:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Now that phylib uses genphy_read_abilities() as fallback, we don't have to set callback get_features any longer. Signed-off-by: Heiner Kallweit --- drivers/net/phy/realtek.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index 5ecbd41ed..d6a10f323 100644 --- a/drivers/net/phy/realtek.c +++ b/drivers/net/phy/realtek.c @@ -199,11 +199,9 @@ static struct phy_driver realtek_drvs[] = { { PHY_ID_MATCH_EXACT(0x00008201), .name = "RTL8201CP Ethernet", - .get_features = genphy_read_abilities, }, { PHY_ID_MATCH_EXACT(0x001cc816), .name = "RTL8201F Fast Ethernet", - .get_features = genphy_read_abilities, .ack_interrupt = &rtl8201_ack_interrupt, .config_intr = &rtl8201_config_intr, .suspend = genphy_suspend, @@ -213,14 +211,12 @@ static struct phy_driver realtek_drvs[] = { }, { PHY_ID_MATCH_EXACT(0x001cc910), .name = "RTL8211 Gigabit Ethernet", - .get_features = genphy_read_abilities, .config_aneg = rtl8211_config_aneg, .read_mmd = &genphy_read_mmd_unsupported, .write_mmd = &genphy_write_mmd_unsupported, }, { PHY_ID_MATCH_EXACT(0x001cc912), .name = "RTL8211B Gigabit Ethernet", - .get_features = genphy_read_abilities, .ack_interrupt = &rtl821x_ack_interrupt, .config_intr = &rtl8211b_config_intr, .read_mmd = &genphy_read_mmd_unsupported, @@ -230,14 +226,12 @@ static struct phy_driver realtek_drvs[] = { }, { PHY_ID_MATCH_EXACT(0x001cc913), .name = "RTL8211C Gigabit Ethernet", - .get_features = genphy_read_abilities, .config_init = rtl8211c_config_init, .read_mmd = &genphy_read_mmd_unsupported, .write_mmd = &genphy_write_mmd_unsupported, }, { PHY_ID_MATCH_EXACT(0x001cc914), .name = "RTL8211DN Gigabit Ethernet", - .get_features = genphy_read_abilities, .ack_interrupt = rtl821x_ack_interrupt, .config_intr = rtl8211e_config_intr, .suspend = genphy_suspend, @@ -245,7 +239,6 @@ static struct phy_driver realtek_drvs[] = { }, { PHY_ID_MATCH_EXACT(0x001cc915), .name = "RTL8211E Gigabit Ethernet", - .get_features = genphy_read_abilities, .ack_interrupt = &rtl821x_ack_interrupt, .config_intr = &rtl8211e_config_intr, .suspend = genphy_suspend, @@ -253,7 +246,6 @@ static struct phy_driver realtek_drvs[] = { }, { PHY_ID_MATCH_EXACT(0x001cc916), .name = "RTL8211F Gigabit Ethernet", - .get_features = genphy_read_abilities, .config_init = &rtl8211f_config_init, .ack_interrupt = &rtl8211f_ack_interrupt, .config_intr = &rtl8211f_config_intr, @@ -264,7 +256,6 @@ static struct phy_driver realtek_drvs[] = { }, { PHY_ID_MATCH_EXACT(0x001cc800), .name = "Generic Realtek PHY", - .get_features = genphy_read_abilities, .suspend = genphy_suspend, .resume = genphy_resume, .read_page = rtl821x_read_page, @@ -272,7 +263,6 @@ static struct phy_driver realtek_drvs[] = { }, { PHY_ID_MATCH_EXACT(0x001cc961), .name = "RTL8366RB Gigabit Ethernet", - .get_features = genphy_read_abilities, .config_init = &rtl8366rb_config_init, /* These interrupts are handled by the irq controller * embedded inside the RTL8366RB, they get unmasked when the -- 2.21.0