From: "Rami Rosen" <ramirose@gmail.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6 1/2] ipv4: minor cleanup in net/ipv4/tcp_ipv4.c (RESEND).
Date: Mon, 16 Jun 2008 12:48:48 +0300 [thread overview]
Message-ID: <eb3ff54b0806160248r5739594dmd4712c88d9db1ccf@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
Hi,
Oops, sorry; I assume best thing is to omit the signed-off-by line
from the body of the patch
(it is in the message instead);
On Mon, Jun 16, 2008 at 12:41 PM, YOSHIFUJI Hideaki / 吉藤英明
<yoshfuji@linux-ipv6.org> wrote:
> In article <eb3ff54b0806160207r473055c3y329b6ec66b902572@mail.gmail.com> (at Mon, 16 Jun 2008 12:07:31 +0300), "Rami Rosen" <ramirose@gmail.com> says:
>
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Would you please fix signed-off-by line in the patches?
>
> --yoshfuji
>
[-- Attachment #2: patch1.txt --]
[-- Type: text/plain, Size: 491 bytes --]
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 97a2300..12695be 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -85,10 +85,6 @@
int sysctl_tcp_tw_reuse __read_mostly;
int sysctl_tcp_low_latency __read_mostly;
-/* Check TCP sequence numbers in ICMP packets. */
-#define ICMP_MIN_LENGTH 8
-
-void tcp_v4_send_check(struct sock *sk, int len, struct sk_buff *skb);
#ifdef CONFIG_TCP_MD5SIG
static struct tcp_md5sig_key *tcp_v4_md5_do_lookup(struct sock *sk,
reply other threads:[~2008-06-16 9:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb3ff54b0806160248r5739594dmd4712c88d9db1ccf@mail.gmail.com \
--to=ramirose@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).