netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rami Rosen" <ramirose@gmail.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6 2/2] ipv6: minor cleanup in net/ipv6/tcp_ipv6.c
Date: Mon, 16 Jun 2008 12:51:35 +0300	[thread overview]
Message-ID: <eb3ff54b0806160251w75b1818dh521f2c8cd8ca0c79@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Hi,
Fixing signed-off by line also in this second patch,
Rami

On Mon, Jun 16, 2008 at 12:41 PM, YOSHIFUJI Hideaki / 吉藤英明
<yoshfuji@linux-ipv6.org> wrote:
> In article <eb3ff54b0806160207r473055c3y329b6ec66b902572@mail.gmail.com> (at Mon, 16 Jun 2008 12:07:31 +0300), "Rami Rosen" <ramirose@gmail.com> says:
>
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Would you please fix signed-off-by line in the patches?
>
> --yoshfuji
>

[-- Attachment #2: patch2.txt --]
[-- Type: text/plain, Size: 797 bytes --]

diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index cb46749..0a437e0 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -72,8 +72,6 @@
 
 static void	tcp_v6_send_reset(struct sock *sk, struct sk_buff *skb);
 static void	tcp_v6_reqsk_send_ack(struct sk_buff *skb, struct request_sock *req);
-static void	tcp_v6_send_check(struct sock *sk, int len,
-				  struct sk_buff *skb);
 
 static int	tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb);
 
@@ -1101,9 +1099,6 @@ static void tcp_v6_send_ack(struct tcp_timewait_sock *tw,
 #ifdef CONFIG_TCP_MD5SIG
 	struct tcp_md5sig_key *key;
 	struct tcp_md5sig_key tw_key;
-#endif
-
-#ifdef CONFIG_TCP_MD5SIG
 	if (!tw && skb->sk) {
 		key = tcp_v6_md5_do_lookup(skb->sk, &ipv6_hdr(skb)->daddr);
 	} else if (tw && tw->tw_md5_keylen) {


             reply	other threads:[~2008-06-16  9:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-16  9:51 Rami Rosen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-16  9:09 [PATCH net-2.6 2/2] ipv6: minor cleanup in net/ipv6/tcp_ipv6.c Rami Rosen
2008-06-17  0:08 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb3ff54b0806160251w75b1818dh521f2c8cd8ca0c79@mail.gmail.com \
    --to=ramirose@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).