* [PATCH] net: bna: remove trailing semicolon in macro definition
@ 2020-11-27 16:55 trix
2020-12-01 3:01 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2020-11-27 16:55 UTC (permalink / raw)
To: rmody, skalluru, davem, kuba
Cc: GR-Linux-NIC-Dev, netdev, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
index f335b7115c1b..4b19855017d7 100644
--- a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
+++ b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
@@ -218,7 +218,7 @@ do { \
/* Set the coalescing timer for the given ib */
#define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer) \
- ((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
+ ((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
/* Acks 'events' # of events for a given ib while disabling interrupts */
#define bna_ib_ack_disable_irq(_i_dbell, _events) \
@@ -260,7 +260,7 @@ do { \
#define bna_txq_prod_indx_doorbell(_tcb) \
(writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
- (_tcb)->q_dbell));
+ (_tcb)->q_dbell))
#define bna_rxq_prod_indx_doorbell(_rcb) \
(writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: bna: remove trailing semicolon in macro definition
2020-11-27 16:55 [PATCH] net: bna: remove trailing semicolon in macro definition trix
@ 2020-12-01 3:01 ` Jakub Kicinski
2020-12-01 17:25 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2020-12-01 3:01 UTC (permalink / raw)
To: trix; +Cc: rmody, skalluru, davem, GR-Linux-NIC-Dev, netdev, linux-kernel
On Fri, 27 Nov 2020 08:55:50 -0800 trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
> index f335b7115c1b..4b19855017d7 100644
> --- a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
> +++ b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
> @@ -218,7 +218,7 @@ do { \
>
> /* Set the coalescing timer for the given ib */
> #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer) \
> - ((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
> + ((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
>
> /* Acks 'events' # of events for a given ib while disabling interrupts */
> #define bna_ib_ack_disable_irq(_i_dbell, _events) \
> @@ -260,7 +260,7 @@ do { \
>
> #define bna_txq_prod_indx_doorbell(_tcb) \
> (writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
> - (_tcb)->q_dbell));
> + (_tcb)->q_dbell))
>
> #define bna_rxq_prod_indx_doorbell(_rcb) \
> (writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \
Same story here as Daniel pointed out for the BPF patch.
There are 2 macros right below here which also have a semicolon at the
end. And these ones are used. So the patch appears to be pretty arbitrary.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: bna: remove trailing semicolon in macro definition
2020-12-01 3:01 ` Jakub Kicinski
@ 2020-12-01 17:25 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2020-12-01 17:25 UTC (permalink / raw)
To: Jakub Kicinski
Cc: rmody, skalluru, davem, GR-Linux-NIC-Dev, netdev, linux-kernel
On 11/30/20 7:01 PM, Jakub Kicinski wrote:
> On Fri, 27 Nov 2020 08:55:50 -0800 trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> index f335b7115c1b..4b19855017d7 100644
>> --- a/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> +++ b/drivers/net/ethernet/brocade/bna/bna_hw_defs.h
>> @@ -218,7 +218,7 @@ do { \
>>
>> /* Set the coalescing timer for the given ib */
>> #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer) \
>> - ((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
>> + ((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
>>
>> /* Acks 'events' # of events for a given ib while disabling interrupts */
>> #define bna_ib_ack_disable_irq(_i_dbell, _events) \
>> @@ -260,7 +260,7 @@ do { \
>>
>> #define bna_txq_prod_indx_doorbell(_tcb) \
>> (writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
>> - (_tcb)->q_dbell));
>> + (_tcb)->q_dbell))
>>
>> #define bna_rxq_prod_indx_doorbell(_rcb) \
>> (writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \
> Same story here as Daniel pointed out for the BPF patch.
>
> There are 2 macros right below here which also have a semicolon at the
> end. And these ones are used. So the patch appears to be pretty arbitrary.
I will add the other macros in the next revision.
Sorry,
Tom
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-01 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 16:55 [PATCH] net: bna: remove trailing semicolon in macro definition trix
2020-12-01 3:01 ` Jakub Kicinski
2020-12-01 17:25 ` Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).