From: Justin Chen <justin.chen@broadcom.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>, netdev@vger.kernel.org
Cc: Doug Berger <opendmb@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Zak Kemble <zakkemble@gmail.com>, Simon Horman <horms@kernel.org>,
Ryo Takakura <ryotkkr98@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
Nicolai Buchwitz <nb@tipi-net.de>
Subject: Re: [PATCH net v2 3/6] net: bcmasp: validate minimum RX packet size in bcmasp_rx_poll()
Date: Fri, 9 Oct 2026 11:36:28 -0700 [thread overview]
Message-ID: <eb4b6a59-2cca-43fc-910c-2a067d165d7d@broadcom.com> (raw)
In-Reply-To: <20261008210621.1374785-4-florian.fainelli@broadcom.com>
On 10/8/26 2:06 PM, Florian Fainelli wrote:
> In bcmasp_rx_poll(), the driver removes a 2-byte alignment pad and
> optionally strips the ETH_FCS_LEN CRC from received packets before
> passing them to eth_type_trans().
>
> If the hardware reports a descriptor size smaller than the sum of the
> 2-byte pad, the Ethernet header (ETH_HLEN), and optional CRC
> (ETH_FCS_LEN), subtracting the pad and CRC lengths underflows u32 len.
> This adds ~4 GiB to rx_bytes statistics, while the undersized frame
> reaches eth_type_trans(), which reads past skb->len into stale buffer
> data.
>
> Check that desc->size is at least (2 + ETH_HLEN + (crc_fwd ? ETH_FCS_LEN
> : 0)) before proceeding to process the descriptor.
>
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Assisted-by: LLM
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Justin Chen <justin.chen@broadcom.com>
next prev parent reply other threads:[~2026-10-09 18:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 21:06 [PATCH net v2 0/6] net: bcmasp: Collection of fixes Florian Fainelli
2026-10-08 21:06 ` [PATCH net v2 1/6] net: bcmasp: fix mib counters struct alignment with ethtool stats Florian Fainelli
2026-10-09 8:42 ` Nicolai Buchwitz
2026-10-09 18:35 ` Justin Chen
2026-10-08 21:06 ` [PATCH net v2 2/6] net: bcmasp: unmap previous DMA mappings on TX map failure Florian Fainelli
2026-10-09 18:36 ` Justin Chen
2026-10-08 21:06 ` [PATCH net v2 3/6] net: bcmasp: validate minimum RX packet size in bcmasp_rx_poll() Florian Fainelli
2026-10-09 18:36 ` Justin Chen [this message]
2026-10-08 21:06 ` [PATCH net v2 4/6] net: bcmasp: fix OF node reference leak for phy_dn Florian Fainelli
2026-10-09 18:36 ` Justin Chen
2026-10-08 21:06 ` [PATCH net v2 6/6] net: bcmasp: fix network filter lookup and wake filter pair allocation Florian Fainelli
2026-10-09 8:55 ` Nicolai Buchwitz
2026-10-09 18:37 ` Justin Chen
[not found] ` <20261008210621.1374785-6-florian.fainelli@broadcom.com>
2026-10-09 18:36 ` [PATCH net v2 5/6] net: bcmasp: account for offload header in TX short packet padding Justin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb4b6a59-2cca-43fc-910c-2a067d165d7d@broadcom.com \
--to=justin.chen@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=ryotkkr98@gmail.com \
--cc=zakkemble@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox