* [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module
@ 2020-03-04 23:24 Taehee Yoo
2020-03-04 23:43 ` subashab
2020-03-05 19:47 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Taehee Yoo @ 2020-03-04 23:24 UTC (permalink / raw)
To: davem, kuba, subashab, stranche, netdev; +Cc: ap420073
This patchset is to cleanup rmnet module code.
1. The first patch is to add module alias
rmnet module can not be loaded automatically because there is no
alias name.
2. The second patch is to add extack error message code.
When rmnet netlink command fails, it doesn't print any error message.
So, users couldn't know the exact reason.
In order to tell the exact reason to the user, the extack error message
is used in this patch.
3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC.
In the sleepable context, GFP_KERNEL can be used.
So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.
Change log:
- v1->v2: change error message in the second patch.
Taehee Yoo (3):
net: rmnet: add missing module alias
net: rmnet: print error message when command fails
net: rmnet: use GFP_KERNEL instead of GFP_ATOMIC
.../ethernet/qualcomm/rmnet/rmnet_config.c | 36 ++++++++++++-------
.../net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 11 +++---
.../net/ethernet/qualcomm/rmnet/rmnet_vnd.h | 3 +-
3 files changed, 32 insertions(+), 18 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module
2020-03-04 23:24 [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module Taehee Yoo
@ 2020-03-04 23:43 ` subashab
2020-03-05 2:53 ` Jakub Kicinski
2020-03-05 19:47 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: subashab @ 2020-03-04 23:43 UTC (permalink / raw)
To: Taehee Yoo; +Cc: davem, kuba, stranche, netdev
On 2020-03-04 16:24, Taehee Yoo wrote:
> This patchset is to cleanup rmnet module code.
>
> 1. The first patch is to add module alias
> rmnet module can not be loaded automatically because there is no
> alias name.
>
> 2. The second patch is to add extack error message code.
> When rmnet netlink command fails, it doesn't print any error message.
> So, users couldn't know the exact reason.
> In order to tell the exact reason to the user, the extack error message
> is used in this patch.
>
> 3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC.
> In the sleepable context, GFP_KERNEL can be used.
> So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.
>
> Change log:
> - v1->v2: change error message in the second patch.
>
> Taehee Yoo (3):
> net: rmnet: add missing module alias
> net: rmnet: print error message when command fails
> net: rmnet: use GFP_KERNEL instead of GFP_ATOMIC
>
> .../ethernet/qualcomm/rmnet/rmnet_config.c | 36 ++++++++++++-------
> .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 11 +++---
> .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h | 3 +-
> 3 files changed, 32 insertions(+), 18 deletions(-)
For the series:
Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module
2020-03-04 23:43 ` subashab
@ 2020-03-05 2:53 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-03-05 2:53 UTC (permalink / raw)
To: subashab; +Cc: Taehee Yoo, davem, stranche, netdev
On Wed, 04 Mar 2020 16:43:58 -0700 subashab@codeaurora.org wrote:
> On 2020-03-04 16:24, Taehee Yoo wrote:
> > This patchset is to cleanup rmnet module code.
> >
> > 1. The first patch is to add module alias
> > rmnet module can not be loaded automatically because there is no
> > alias name.
> >
> > 2. The second patch is to add extack error message code.
> > When rmnet netlink command fails, it doesn't print any error message.
> > So, users couldn't know the exact reason.
> > In order to tell the exact reason to the user, the extack error message
> > is used in this patch.
> >
> > 3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC.
> > In the sleepable context, GFP_KERNEL can be used.
> > So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.
> >
> > Change log:
> > - v1->v2: change error message in the second patch.
>
> For the series:
>
> Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
LGTM as well, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module
2020-03-04 23:24 [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module Taehee Yoo
2020-03-04 23:43 ` subashab
@ 2020-03-05 19:47 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-03-05 19:47 UTC (permalink / raw)
To: ap420073; +Cc: kuba, subashab, stranche, netdev
From: Taehee Yoo <ap420073@gmail.com>
Date: Wed, 4 Mar 2020 23:24:15 +0000
> This patchset is to cleanup rmnet module code.
>
> 1. The first patch is to add module alias
> rmnet module can not be loaded automatically because there is no
> alias name.
>
> 2. The second patch is to add extack error message code.
> When rmnet netlink command fails, it doesn't print any error message.
> So, users couldn't know the exact reason.
> In order to tell the exact reason to the user, the extack error message
> is used in this patch.
>
> 3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC.
> In the sleepable context, GFP_KERNEL can be used.
> So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.
>
> Change log:
> - v1->v2: change error message in the second patch.
Looks good, series applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-05 19:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-04 23:24 [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module Taehee Yoo
2020-03-04 23:43 ` subashab
2020-03-05 2:53 ` Jakub Kicinski
2020-03-05 19:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).