Re: [PATCH RFC net] net: bcmgenet: fix leaking and racing timeout handler

[Justin Chen <justin.chen@broadcom.com>]

On 3/25/26 3:00 PM, Florian Fainelli wrote:
> On 3/25/26 10:36, justin.chen@broadcom.com wrote:
>> From: Justin Chen <justin.chen@broadcom.com>
>>
>> The bcmgenet_timeout handler tries to take down all tx queues when
>> a single queue times out. This is over zealous and causes many race
>> conditions with queues that are still chugging along. Instead lets
>> only restart the timed out queue.
>>
>> While reclaiming the tx queue we fast forward the write pointer to
>> drop any data in flight. These dropped frames are not added back
>> to the pool of free bds. We also need to tell the netdev that we
>> are dropping said data.
>>
>> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> 
> The first bits in bcmgenet_tx_reclaim would be fixing:
> 
> Fixes: f1bacae8b655 ("net: bcmgenet: support reclaiming unsent Tx packets")
> 
> and the other part in bcmgenet_tx_timeout() would have:
> 
> Fixes: 13ea657806cf ("net: bcmgenet: improve TX timeout")
> 
> Both fixes look good to me:
> 
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>

Thanks. I will resend v2 as two patches once we get verification the 
patch is working as intended.

Justin