From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 108E4C282C8 for ; Mon, 28 Jan 2019 20:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA70421738 for ; Mon, 28 Jan 2019 20:54:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m254e6qM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726984AbfA1UyY (ORCPT ); Mon, 28 Jan 2019 15:54:24 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:45931 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbfA1UyY (ORCPT ); Mon, 28 Jan 2019 15:54:24 -0500 Received: by mail-io1-f65.google.com with SMTP id c2so14668492iom.12 for ; Mon, 28 Jan 2019 12:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o5/coJRntTqVAPlSs+JvOvHv6gAGZoZIpZZamW87isc=; b=m254e6qM8JbQnwRGLqUlS4jvL1y3uMe+oa0PM/v8+bFF39+eSTvlAQgmEj5jW1pht8 sug9CgfMS8THqpg3hxwzrzgczBPmgl15MCxEjBWaMyewJT4hq0t/oHzXynMt/B63ylHT VI/e+USJKjfnN5o9aAVBx7CVAbZzQq5bxcweRh5oKGhkwJuMrRvwH8RU1jpFldvi03Dm 0lwNP+0xfX6l0wACrTY104Wacn2W87O6Z+qVtniOiwOVp1fwm7VVVFsc0ED3RmPh7cJr 4sa9VjmTR75ybUu3wFnSaKPNuMfE77/8vy8t+ndYnT6s80TDkVPBoCruOFqSul6URYtU z5ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o5/coJRntTqVAPlSs+JvOvHv6gAGZoZIpZZamW87isc=; b=pjuq65eiR3LnHMi76d/YccQWnSGa5L4eg4nC6JeMhh7+uvZ4qk16YhUfk3q7rJnLvS 7T9otUNDAoyeFUc7Cqgw6+9XrtNhyj56cFJL0oShaIbi4YhaJawYOHGTVq3Rgolq9Vyp P5JnEbn1hwKNTPijJ7jQ7fRz5fali1xdnuCBkXeLmiHyl921OZXTSFeKE5BKmThLgEPS scf0UbR7bUcSkdY0lurL/WhzI4XP/BUDdfBL7y8f3KJuTCAHzB5q5wnhPGC0J0E/VTLf +21WK982EJTRpkFCk6G54vTnR9Q4gRcwlsg5TJY9JfVLrBX+K/8bMUeo/vdAjPyUFjTD dGHQ== X-Gm-Message-State: AHQUAuZpohVL7jim19+g+2b6EHcwFBvgkDwMgcQK3DxmMTHc/XjIBtg/ +cPohj/mzgxJWiyIJsY30BtR0vb0 X-Google-Smtp-Source: AHgI3IY7bFVjKg88BE8ghWFRQgJJDsf3DTTOTHmKy+H1dN+Vi3kKhgBmIhx65+8hgX0MvV/CYKa7kw== X-Received: by 2002:a5d:9ad8:: with SMTP id x24mr13442061ion.19.1548708863074; Mon, 28 Jan 2019 12:54:23 -0800 (PST) Received: from [192.168.86.250] ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id o192sm283033itb.31.2019.01.28.12.54.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 12:54:22 -0800 (PST) Subject: Re: [PATCH bpf-next v4 4/7] samples/bpf: Extend RLIMIT_MEMLOCK for xdp_{sample_pkts, router_ipv4} To: Maciej Fijalkowski , daniel@iogearbox.net, ast@kernel.org Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com References: <20190128191613.11705-1-maciejromanfijalkowski@gmail.com> <20190128191613.11705-5-maciejromanfijalkowski@gmail.com> From: John Fastabend Message-ID: Date: Mon, 28 Jan 2019 12:54:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190128191613.11705-5-maciejromanfijalkowski@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/28/19 11:16 AM, Maciej Fijalkowski wrote: > From: Maciej Fijalkowski > > There is a common problem with xdp samples that happens when user wants > to run a particular sample and some bpf program is already loaded. The > default 64kb RLIMIT_MEMLOCK resource limit will cause a following error > (assuming that xdp sample that is failing was converted to libbpf > usage): > > libbpf: Error in bpf_object__probe_name():Operation not permitted(1). > Couldn't load basic 'r0 = 0' BPF program. > libbpf: failed to load object './xdp_sample_pkts_kern.o' > > Fix it in xdp_sample_pkts and xdp_router_ipv4 by setting RLIMIT_MEMLOCK > to RLIM_INFINITY. > > Signed-off-by: Maciej Fijalkowski > Reviewed-by: Jakub Kicinski > Acked-by: Jesper Dangaard Brouer > --- Seems we do this for most samples so nice to have here as well. Acked-by: John Fastabend