From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52053C433FE for ; Fri, 18 Nov 2022 15:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242431AbiKRPlU (ORCPT ); Fri, 18 Nov 2022 10:41:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242352AbiKRPlN (ORCPT ); Fri, 18 Nov 2022 10:41:13 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE0AB78D4B; Fri, 18 Nov 2022 07:41:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 96084B8244F; Fri, 18 Nov 2022 15:41:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E359AC433B5; Fri, 18 Nov 2022 15:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668786063; bh=R4xBJmP/myMQ0Kip18TRQGWMGPC+256bduAJsZzqgm8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Pt0nEkiYP3Ivn4a4HL4M+vbconKZ7ATVzTHnVeCQ+LegKL8X286/oC1lyMsME/OXW ZMbTuE2qFVQLMuF8va+AOyLbVPqK30Yu74zham5+Guz2H9iplrRwJvZk2Is293TSPD Skuk3pPei4Cuitu/21dNYeFzCwmxHf7v59A+7rRRAxJE6dirbxk9Ksfgz/IFX7j6xF tpu6JsI5ZPCdgloE6dPrd09m5fsG22G+Wyl0onBDvdhzivzrtHmy7kfgJoE0jqoS+j x+zKiG91/B9E/11/sPBgiRXd2CMmtjSTAlm1xjUE/xgVSZcw2IqTkxjYikZ4zsPMWw x/ux5+87roo7Q== Message-ID: Date: Fri, 18 Nov 2022 08:41:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH] ipv4/fib: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Content-Language: en-US To: Kees Cook , Jakub Kicinski Cc: "David S. Miller" , Hideaki YOSHIFUJI , Eric Dumazet , Paolo Abeni , "Gustavo A. R. Silva" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20221118042142.never.400-kees@kernel.org> From: David Ahern In-Reply-To: <20221118042142.never.400-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/17/22 9:21 PM, Kees Cook wrote: > Zero-length arrays are deprecated[1] and are being replaced with > flexible array members in support of the ongoing efforts to tighten the > FORTIFY_SOURCE routines on memcpy(), correctly instrument array indexing > with UBSAN_BOUNDS, and to globally enable -fstrict-flex-arrays=3. > > Replace zero-length array with flexible-array member in struct key_vector. > > This results in no differences in binary output. > > [1] https://github.com/KSPP/linux/issues/78 > > Cc: Jakub Kicinski > Cc: "David S. Miller" > Cc: Hideaki YOSHIFUJI > Cc: David Ahern > Cc: Eric Dumazet > Cc: Paolo Abeni > Cc: "Gustavo A. R. Silva" > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook > --- > net/ipv4/fib_trie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: David Ahern