From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO
Date: Tue, 27 Feb 2018 15:46:09 -0800 [thread overview]
Message-ID: <ebcc6603-1f4c-7af9-83d2-7c3ccae7c994@gmail.com> (raw)
In-Reply-To: <20180227231000.GA13978@lunn.ch>
On 02/27/2018 03:10 PM, Andrew Lunn wrote:
>> Nack on patches 1 and 3, because I am slowly resuming work on an x86
>> platform driver that uses the mdio-gpio driver with platform data, and
>> DT is not an option there, and I would rather not have to revert your
>> changes.
>
> Hi Florian
>
> Would it be O.K. to change the platform_data to use a gpio descriptor,
> rather than gpio number and active_low flag? That would simplify a lot
> of code.
Oh absolutely, the move towards gpio descriptors is entirely fine and
reasonable, it was just the plain removal of platform_data instantiation
that I am objecting to. Thanks!
--
Florian
next prev parent reply other threads:[~2018-02-27 23:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 12:51 [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 1/5] net: mdio-gpio: Localize platform data Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 2/5] net: mdio-gpio: Allocate state in probe() Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 3/5] net: mdio-gpio: Remove non-DT probe path Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 4/5] net: mdio-gpio: Merge platform data into state Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 5/5] net: mdio-gpio: Move to gpiod API Linus Walleij
2018-02-25 19:08 ` [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO Andrew Lunn
2018-02-27 8:53 ` Linus Walleij
2018-02-27 14:00 ` Florian Fainelli
2018-02-27 23:10 ` Andrew Lunn
2018-02-27 23:46 ` Florian Fainelli [this message]
2018-03-02 9:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebcc6603-1f4c-7af9-83d2-7c3ccae7c994@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).