From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f179.google.com ([209.85.220.179]:37227 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbeB0XqT (ORCPT ); Tue, 27 Feb 2018 18:46:19 -0500 Received: by mail-qk0-f179.google.com with SMTP id y137so830911qka.4 for ; Tue, 27 Feb 2018 15:46:19 -0800 (PST) Subject: Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO To: Andrew Lunn Cc: Linus Walleij , "David S . Miller" , netdev@vger.kernel.org, Laurent Pinchart References: <20180225125132.25275-1-linus.walleij@linaro.org> <421c14be-a712-5427-f3d6-ba29d69ed02c@gmail.com> <20180227231000.GA13978@lunn.ch> From: Florian Fainelli Message-ID: Date: Tue, 27 Feb 2018 15:46:09 -0800 MIME-Version: 1.0 In-Reply-To: <20180227231000.GA13978@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 02/27/2018 03:10 PM, Andrew Lunn wrote: >> Nack on patches 1 and 3, because I am slowly resuming work on an x86 >> platform driver that uses the mdio-gpio driver with platform data, and >> DT is not an option there, and I would rather not have to revert your >> changes. > > Hi Florian > > Would it be O.K. to change the platform_data to use a gpio descriptor, > rather than gpio number and active_low flag? That would simplify a lot > of code. Oh absolutely, the move towards gpio descriptors is entirely fine and reasonable, it was just the plain removal of platform_data instantiation that I am objecting to. Thanks! -- Florian