From: Roger Quadros <rogerq@kernel.org>
To: Nicolas Pitre <nico@fluxnic.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: Nicolas Pitre <npitre@baylibre.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 2/2] net: ethernet: ti: am65-cpsw: avoid devm_alloc_etherdev, fix module removal
Date: Mon, 7 Oct 2024 14:37:37 +0300 [thread overview]
Message-ID: <ebd0bc6c-355e-4bd6-8eaa-b4ec0e5212f1@kernel.org> (raw)
In-Reply-To: <20241004041218.2809774-3-nico@fluxnic.net>
On 04/10/2024 07:10, Nicolas Pitre wrote:
> From: Nicolas Pitre <npitre@baylibre.com>
>
> Usage of devm_alloc_etherdev_mqs() conflicts with
> am65_cpsw_nuss_cleanup_ndev() as the same struct net_device instances
> get unregistered twice. Switch to alloc_etherdev_mqs() and make sure
> am65_cpsw_nuss_cleanup_ndev() unregisters and frees those net_device
> instances properly.
>
> With this, it is finally possible to rmmod the driver without oopsing
> the kernel.
>
> Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
> Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
Reviewed-by: Roger Quadros <roger@kernel.org>
next prev parent reply other threads:[~2024-10-07 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 4:10 [PATCH net v3 0/2] fix ti-am65-cpsw-nuss module removal Nicolas Pitre
2024-10-04 4:10 ` [PATCH net v3 1/2] net: ethernet: ti: am65-cpsw: prevent WARN_ON upon " Nicolas Pitre
2024-10-04 8:48 ` Roger Quadros
2024-10-04 4:10 ` [PATCH net v3 2/2] net: ethernet: ti: am65-cpsw: avoid devm_alloc_etherdev, fix " Nicolas Pitre
2024-10-04 9:09 ` Roger Quadros
2024-10-04 12:57 ` Roger Quadros
2024-10-04 15:37 ` Nicolas Pitre
2024-10-04 19:50 ` Roger Quadros
2024-10-04 21:17 ` Nicolas Pitre
2024-10-05 20:26 ` Nicolas Pitre
2024-10-07 11:37 ` Roger Quadros
2024-10-07 11:37 ` Roger Quadros [this message]
2024-10-08 8:50 ` [PATCH net v3 0/2] fix ti-am65-cpsw-nuss " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd0bc6c-355e-4bd6-8eaa-b4ec0e5212f1@kernel.org \
--to=rogerq@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=npitre@baylibre.com \
--cc=pabeni@redhat.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).