From: "Catherine Zhang" <czhang.us@gmail.com>
To: "James Morris" <jmorris@namei.org>
Cc: "Stephen Hemminger" <shemminger@osdl.org>,
"Catherine Zhang" <cxzhang@watson.ibm.com>,
netdev@vger.kernel.org, davem@davemloft.net, jmorris@redhat.com,
chrisw@osdl.org, herbert@gondor.apana.org.au, sds@tycho.nsa.gov,
tjaeger@cse.psu.edu, akpm@osdl.org, latten@austin.ibm.com,
sergeh@us.ibm.com, gcwilson@us.ibm.com
Subject: Re: updated [Patch 1/1] AF_UNIX Datagram getpeersec
Date: Sun, 18 Jun 2006 00:46:48 -0400 [thread overview]
Message-ID: <ebe353740606172146ob1e8cefpe489c58b1fb07ba0@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0606171151320.16944@d.namei>
On 6/17/06, James Morris <jmorris@namei.org> wrote:
> On Fri, 16 Jun 2006, Stephen Hemminger wrote:
>
> > This is so short, it would make sense to put it in scm.h
> > and why not have it return the value instead of call by reference?
> > Same goes for selinux_get_inode_sid
>
> Actually, all of the SELinux API functions are like this, and I'm not sure
> why for void return methods (it's a good idea when they return errnos).
>
Yes, the reason I used void return method is consistency with the
remaining SELinux API functions.
> Once this area has settled down (post 2.6.18), I'm planning to do some
> cleanups for this API anyway, and can fix these all at the same time.
>
OK.
Thanks,
Catherine
prev parent reply other threads:[~2006-06-18 4:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-17 3:54 updated [Patch 1/1] AF_UNIX Datagram getpeersec Catherine Zhang
2006-06-17 4:16 ` Stephen Hemminger
2006-06-17 6:47 ` Xiaolan Zhang
2006-06-17 15:46 ` James Morris
2006-06-17 15:55 ` James Morris
2006-06-18 4:46 ` Catherine Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe353740606172146ob1e8cefpe489c58b1fb07ba0@mail.gmail.com \
--to=czhang.us@gmail.com \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=cxzhang@watson.ibm.com \
--cc=davem@davemloft.net \
--cc=gcwilson@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=jmorris@redhat.com \
--cc=latten@austin.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=sergeh@us.ibm.com \
--cc=shemminger@osdl.org \
--cc=tjaeger@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).