From: Felix Fietkau <nbd@nbd.name>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] net: add TCP fraglist GRO support
Date: Tue, 23 Apr 2024 14:23:32 +0200 [thread overview]
Message-ID: <ebe85dca-e0e9-4c55-a15d-20d340f66848@nbd.name> (raw)
In-Reply-To: <CANn89iLddm704LHPDnnoF2RbCfvrivAz0e6HTeiBARmvzoUBjA@mail.gmail.com>
On 23.04.24 14:11, Eric Dumazet wrote:
> On Tue, Apr 23, 2024 at 1:55 PM Felix Fietkau <nbd@nbd.name> wrote:
>>
>> In the world of consumer-grade WiFi devices, there are a lot of chipsets
>> with limited or nonexistent SG support, and very limited checksum
>> offload capabilities on Ethernet. The WiFi side of these devices is
>> often even worse. I think fraglist GRO is a decent fallback for the
>> inevitable corner cases.
>
> What about netfilter and NAT ? Are they okay with NETIF_F_FRAGLIST_GRO already ?
>
> Many of these devices are probably using NAT.
In my tests, nftables NAT works just fine, both with and without
flowtable offloading. I didn't see anything in netfilter that would have
a problem with this.
- Felix
next prev parent reply other threads:[~2024-04-23 12:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 9:41 [RFC] net: add TCP fraglist GRO support Felix Fietkau
2024-04-23 10:15 ` Eric Dumazet
2024-04-23 10:25 ` Felix Fietkau
2024-04-23 11:17 ` Eric Dumazet
2024-04-23 11:55 ` Felix Fietkau
2024-04-23 12:11 ` Eric Dumazet
2024-04-23 12:23 ` Felix Fietkau [this message]
2024-04-23 13:07 ` Eric Dumazet
2024-04-23 14:34 ` Paolo Abeni
2024-04-23 16:55 ` Felix Fietkau
2024-04-24 1:24 ` Willem de Bruijn
2024-04-24 13:50 ` Felix Fietkau
2024-04-24 14:30 ` Willem de Bruijn
2024-04-24 16:26 ` Felix Fietkau
2024-04-23 15:03 ` David Ahern
2024-04-23 15:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe85dca-e0e9-4c55-a15d-20d340f66848@nbd.name \
--to=nbd@nbd.name \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox