From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>, eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next] neighbor: Add protocol attribute
Date: Mon, 10 Dec 2018 19:47:33 -0700 [thread overview]
Message-ID: <ebf2bf81-64a0-6ce1-d693-e07da0f592a3@gmail.com> (raw)
In-Reply-To: <20181207.154553.2153174795925914538.davem@davemloft.net>
On 12/7/18 4:45 PM, David Miller wrote:
>
> Right, neigh->ha[] should probably be kept 8-byte aligned.
>
>From what I can see ha is only used with memcpy, and neighbour struct is
annotated with __randomize_layout. Are you saying that ha should be
marked with __aligned(8)?
@@ -150,7 +150,7 @@ struct neighbour {
__u8 type;
__u8 dead;
seqlock_t ha_lock;
- unsigned char ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned
long))];
+ unsigned char ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned
long))] __aligned(8);
struct hh_cache hh;
int (*output)(struct neighbour *, struct
sk_buff *);
const struct neigh_ops *ops;
next prev parent reply other threads:[~2018-12-11 2:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 21:49 [PATCH net-next] neighbor: Add protocol attribute David Ahern
2018-12-07 22:20 ` Eric Dumazet
2018-12-07 22:24 ` David Ahern
2018-12-07 23:03 ` Eric Dumazet
2018-12-07 23:45 ` David Miller
2018-12-11 2:47 ` David Ahern [this message]
2018-12-11 5:59 ` David Miller
2018-12-11 15:22 ` David Ahern
2018-12-14 22:38 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2018-12-15 22:09 David Ahern
2018-12-16 20:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebf2bf81-64a0-6ce1-d693-e07da0f592a3@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).