From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: Attribute failed policy validation
Date: Wed, 24 Oct 2018 08:58:16 -0600
Message-ID: <ebf41026-9efb-a4e4-b9d7-82ace844cc02@gmail.com>
References: <2054265373.707198.1540374961653@mail.libero.it>
 <20181024130742.777kcbzp667mo5rm@breakpoint.cc>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, dsahern@gmail.com
To: Florian Westphal <fw@strlen.de>, Marco Berizzi <pupilla@libero.it>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f172.google.com ([209.85.214.172]:44361 "EHLO
        mail-pl1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726521AbeJXX0q (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 24 Oct 2018 19:26:46 -0400
Received: by mail-pl1-f172.google.com with SMTP id d23-v6so2340475pls.11
        for <netdev@vger.kernel.org>; Wed, 24 Oct 2018 07:58:19 -0700 (PDT)
In-Reply-To: <20181024130742.777kcbzp667mo5rm@breakpoint.cc>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/24/18 7:07 AM, Florian Westphal wrote:
> Marco Berizzi <pupilla@libero.it> wrote:
> 
> [ CC David ]
> 
>> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
>> Error: Attribute failed policy validation.
> 
> caused by:
> commit 8b4c3cdd9dd8290343ce959a132d3b334062c5b9
> net: sched: Add policy validation for tc attributes
> 
> Looks like TCA_OPTIONS is NLA_BINARY in hfsc case, so
> we can't enforce NLA_NESTED :-(
> 

Yep. I'll send a fix.