From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 042E83A59B1; Thu, 2 Jul 2026 18:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.161 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783016829; cv=none; b=CacJnOnM6UCSlBpAOCJIC0lp4G+KjviA2k8XaesFc5paBruyHrWaGg4tc1APGCnuIGMtCUqxV6ehaSLSBM1gzKcvmrm0LEG9WXUwT/rRFWDekU/f5ExmEHjt/abYqDRdri0HRAAU2msD+JzShJRx01OYqaQTYczFaz2Gu9xFCmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783016829; c=relaxed/simple; bh=NeMrv1nWkBCLLNUEg54JNV8fu8oY4LOMjJiLTxtpX8c=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=P3YeIJnqI8DVENW8pEucDOCl/dhLbs0ZHKMcVFAynARihW0/lIXw755Kp9hcOHmNGC1QzCcNPvZqSXc74xkvhv+4ECl+HWqdlCneFT0maARnyxgU0Z0OerNbX+54RG4cCC8TuEmKl+dsTKUqgE6qG4AdHNkHb4ij/u8BxXMcmFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=FwJfTHwE; arc=none smtp.client-ip=80.241.56.161 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="FwJfTHwE" Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4grlXH0tTbz9tx6; Thu, 2 Jul 2026 20:19:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1783016367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=384tUyVKGcuexzJQm/Gbh8Apy/SFEokWG8t45DtqO9k=; b=FwJfTHwEggHqrODTUm9G5yRboHU/FWJxCiiGONmd96NlrhJBbXgNMrQu1iNOagteulFpWo n1iIHjQN204RzY1VpjjIaX/Xo8hslqOlag4iGn9ZjDmI8Pet9LSF0wBTVWi34NIRChgsFW H3gkSdR8P2Vlidxev5ZPM/vkKEgJjBXVuZuvg1PATNdBG66urfMNO2LqL2foUxSRTvMCRy hYo6okX3fE3pKUTkyispai+z4TKUD5UhU9lqnjmI2Ov3JWaaljLStpNRLQ6w2uO9t+/iBY /OBT3vG6FbvaLpNqJN9hEETQvuzcyQkuje8I8bHJlnYGLT4WT4bzn16j4ghfUw== Message-ID: Subject: Re: [PATCH net-next 2/4] net: usb: centralize usbnet_cdc_zte_rx_fixup in usbnet From: Manuel Ebner To: Oliver Neukum , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shaoxul@foxmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 02 Jul 2026 20:19:21 +0200 In-Reply-To: <20260702143142.890654-3-oneukum@suse.com> References: <20260702143142.890654-1-oneukum@suse.com> <20260702143142.890654-3-oneukum@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MBO-RS-META: yojdsnwtbuix6fubd8wh6scysfssof5k X-MBO-RS-ID: d1d3bf10343cb94ada5 On Thu, 2026-07-02 at 16:25 +0200, Oliver Neukum wrote: > This helper is used by multiple drivers using usbnet. > It is better to be provided by usbnet than one of them. >=20 > Signed-off-by: Oliver Neukum > --- > =C2=A0drivers/net/usb/cdc_ether.c | 19 ------------------- > =C2=A0drivers/net/usb/usbnet.c=C2=A0=C2=A0=C2=A0 | 19 +++++++++++++++++++ > =C2=A02 files changed, 19 insertions(+), 19 deletions(-) >=20 > ... >=20 > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index 5544af1f4aa5..7beea6d0e731 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -2347,6 +2347,25 @@ void usbnet_cdc_status(struct usbnet *dev, struct = urb *urb) > =C2=A0 } > =C2=A0} > =C2=A0EXPORT_SYMBOL_GPL(usbnet_cdc_status); > + > +/* Make sure packets have correct destination MAC address /*=C2=A0 * Make sure packets have the correct destination MAC address > + * > + * A firmware bug observed on some devices (ZTE MF823/831/910) is that t= he > + * device sends packets with a static, bogus, random MAC address (event = if (even if the device ... > + * device MAC address has been updated). Always set MAC address to that = of the > + * device. Always set the MAC address to the one of your device. Thanks Manuel > + * device. > + */ > +int usbnet_cdc_zte_rx_fixup(struct usbnet *dev, struct sk_buff *skb) > +{ > + if (skb->len < ETH_HLEN || !(skb->data[0] & 0x02)) > + return 1; > + > + skb_reset_mac_header(skb); > + ether_addr_copy(eth_hdr(skb)->h_dest, dev->net->dev_addr); > + > + return 1; > +} > +EXPORT_SYMBOL_GPL(usbnet_cdc_zte_rx_fixup); > =C2=A0/*-----------------------------------------------------------------= --------*/ > =C2=A0 > =C2=A0static int __init usbnet_init(void)