From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nambiar, Amritha" Subject: Re: [net-next,RFC PATCH] Introduce TC Range classifier Date: Fri, 14 Sep 2018 18:29:05 -0700 Message-ID: References: <153687160312.43503.11156697286063840163.stgit@anamhost.jf.intel.com> <20180914094932.GK25110@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , David Miller , Alexander Duyck , Jakub Kicinski , sridhar.samudrala@intel.com, Jamal Hadi Salim , Jesse Brandeburg To: Cong Wang , Jiri Pirko Return-path: Received: from mga11.intel.com ([192.55.52.93]:46136 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbeIOGqq (ORCPT ); Sat, 15 Sep 2018 02:46:46 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/14/2018 2:09 PM, Cong Wang wrote: > On Fri, Sep 14, 2018 at 2:53 AM Jiri Pirko wrote: >> >> Thu, Sep 13, 2018 at 10:52:01PM CEST, amritha.nambiar@intel.com wrote: >>> This patch introduces a TC range classifier to support filtering based >>> on ranges. Only port-range filters are supported currently. This can >>> be combined with flower classifier to support filters that are a >>> combination of port-ranges and other parameters based on existing >>> fields supported by cls_flower. The 'goto chain' action can be used to >>> combine the flower and range filter. >>> The filter precedence is decided based on the 'prio' value. >> >> For example Spectrum ASIC supports mask-based and range-based matching >> in a single TCAM rule. No chains needed. Also, I don't really understand >> why is this a separate cls. I believe that this functionality should be >> put as an extension of existing cls_flower. > > Exactly. u32 filters support range matching too with proper masks. > Can u32 filters support ranges that are not power-of-2 ?