From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>, nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: ipmr: fix unresolved entry dumps
Date: Thu, 18 Oct 2018 09:16:17 -0600 [thread overview]
Message-ID: <ec18010b-cd8a-f419-a929-c0b1a0a09928@gmail.com> (raw)
In-Reply-To: <20181017.223629.857704876875928943.davem@davemloft.net>
On 10/17/18 11:36 PM, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Date: Wed, 17 Oct 2018 22:34:34 +0300
>
>> If the skb space ends in an unresolved entry while dumping we'll miss
>> some unresolved entries. The reason is due to zeroing the entry counter
>> between dumping resolved and unresolved mfc entries. We should just
>> keep counting until the whole table is dumped and zero when we move to
>> the next as we have a separate table counter.
>>
>> Reported-by: Colin Ian King <colin.king@canonical.com>
>> Fixes: 8fb472c09b9d ("ipmr: improve hash scalability")
>> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
> Applied and queued up for -stable.
>
FYI: on the net to net-next merge, those 2 lines were moved to
mr_table_dump.
next prev parent reply other threads:[~2018-10-18 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 18:22 ipmr, ip6mr: Unite dumproute flows Colin Ian King
2018-10-17 18:49 ` Nikolay Aleksandrov
2018-10-17 19:34 ` [PATCH net] net: ipmr: fix unresolved entry dumps Nikolay Aleksandrov
2018-10-17 19:35 ` Nikolay Aleksandrov
2018-10-18 5:36 ` David Miller
2018-10-18 15:16 ` David Ahern [this message]
2018-10-18 23:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec18010b-cd8a-f419-a929-c0b1a0a09928@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).