From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next v3] Add Common Applications Kept Enhanced (cake)
 qdisc
Date: Wed, 25 Apr 2018 08:48:30 -0700
Message-ID: <ec338591-4c9d-aab6-a8a1-75c898ff52fb@gmail.com>
References: <20180425134249.21300-1-toke@toke.dk>
 <e27a6618-3a68-fa60-53a0-109b4df70482@gmail.com> <878t9b5n0q.fsf@toke.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@toke.dk>,
        Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f47.google.com ([74.125.83.47]:33907 "EHLO
        mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754655AbeDYPsc (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 25 Apr 2018 11:48:32 -0400
Received: by mail-pg0-f47.google.com with SMTP id p10so13623162pgn.1
        for <netdev@vger.kernel.org>; Wed, 25 Apr 2018 08:48:31 -0700 (PDT)
In-Reply-To: <878t9b5n0q.fsf@toke.dk>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 04/25/2018 08:22 AM, Toke Høiland-Jørgensen wrote:

> Hmm, because pure ACKs are not generally aggregated (sorry, I'm not
> quite clear on when exactly GSO will kick in)?


A GSO packet must contain payload in each of its segment.

There is no way some ack aggregation logic could build a GSO packet out of pure acks.