From: Gal Pressman <gal@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>, Tariq Toukan <tariqt@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, Moshe Shemesh <moshe@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next V2 3/5] net/mlx5e: Report TX csum netdev stats
Date: Thu, 12 Mar 2026 11:50:10 +0200 [thread overview]
Message-ID: <ec3a32e5-f866-4cb8-bbef-1bce699c461b@nvidia.com> (raw)
In-Reply-To: <20260310201852.0d5d1712@kernel.org>
On 11/03/2026 5:18, Jakub Kicinski wrote:
> On Mon, 9 Mar 2026 11:55:17 +0200 Tariq Toukan wrote:
>> Report TX checksum statistics via the netdev queue stats API by mapping
>> the existing csum_none and csum_partial counters to the csum_none and
>> needs_csum fields.
>
> -
> name: tx-needs-csum
> doc: |
> Number of packets that required the device to calculate the checksum.
> This counter includes the number of GSO wire packets for which device
> calculated the L4 checksum.
> type: uint
Yea, we count GSO packets as one, so not a direct fit.
>
> Looking at drivers currently implementing this it seems like the idea
> was to avoid having to increment two counters in the drivers, given
> that TSO always implies csum offload
I don't think I understand what you're trying to say here.
next prev parent reply other threads:[~2026-03-12 9:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 9:55 [PATCH net-next V2 0/5] net/mlx5e: Report more netdev stats Tariq Toukan
2026-03-09 9:55 ` [PATCH net-next V2 1/5] net/mlx5e: Report hw_gso_packets and hw_gso_bytes " Tariq Toukan
2026-03-11 3:12 ` Jakub Kicinski
2026-03-12 9:49 ` Gal Pressman
2026-03-09 9:55 ` [PATCH net-next V2 2/5] net/mlx5e: Report RX HW-GRO " Tariq Toukan
2026-03-11 3:14 ` Jakub Kicinski
2026-03-09 9:55 ` [PATCH net-next V2 3/5] net/mlx5e: Report TX csum " Tariq Toukan
2026-03-11 3:18 ` Jakub Kicinski
2026-03-12 9:50 ` Gal Pressman [this message]
2026-03-12 14:22 ` Jakub Kicinski
2026-03-09 9:55 ` [PATCH net-next V2 4/5] net/mlx5e: Report RX " Tariq Toukan
2026-03-11 3:20 ` Jakub Kicinski
2026-03-12 9:50 ` Gal Pressman
2026-03-09 9:55 ` [PATCH net-next V2 5/5] net/mlx5e: Report stop and wake TX queue stats Tariq Toukan
2026-03-10 17:38 ` [PATCH net-next V2 0/5] net/mlx5e: Report more netdev stats Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec3a32e5-f866-4cb8-bbef-1bce699c461b@nvidia.com \
--to=gal@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox