From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [bpf PATCH] bpf: selftest fix for sockmap Date: Wed, 13 Jun 2018 10:52:07 -0700 Message-ID: References: <20180611184735.31255.51105.stgit@john-Precision-Tower-5810> <0e4b873d-7e2d-7683-c7cb-0a0112d123a5@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Daniel Borkmann , ast@kernel.org Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:35184 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935000AbeFMRwv (ORCPT ); Wed, 13 Jun 2018 13:52:51 -0400 Received: by mail-io0-f193.google.com with SMTP id u4-v6so4370883iof.2 for ; Wed, 13 Jun 2018 10:52:50 -0700 (PDT) In-Reply-To: <0e4b873d-7e2d-7683-c7cb-0a0112d123a5@iogearbox.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/12/2018 05:31 PM, Daniel Borkmann wrote: > On 06/11/2018 08:47 PM, John Fastabend wrote: >> In selftest test_maps the sockmap test case attempts to add a socket >> in listening state to the sockmap. This is no longer a valid operation >> so it fails as expected. However, the test wrongly reports this as an >> error now. Fix the test to avoid adding sockets in listening state. >> >> Fixes: 945ae430aa44 ("bpf: sockmap only allow ESTABLISHED sock state") >> Signed-off-by: John Fastabend > > (fyi, discussed with John that this will be enrolled into the set of > fixes he has pending for bpf since the test is related to the one > restricting to ESTABLISHED state.) > Patch part of this series now, https://patchwork.ozlabs.org/project/netdev/list/?series=49988