netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Zahka <daniel.zahka@gmail.com>
To: Saeed Mahameed <saeed@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Simon Horman <horms@kernel.org>
Subject: Re: [PATCH V7 net-next 02/11] net/mlx5: Implement cqe_compress_type via devlink params
Date: Fri, 17 Oct 2025 17:51:25 -0400	[thread overview]
Message-ID: <ec51df17-260e-4ec9-a44a-9f0c3d3a2766@gmail.com> (raw)
In-Reply-To: <20250907012953.301746-3-saeed@kernel.org>



On 9/6/25 9:29 PM, Saeed Mahameed wrote:
> From: Saeed Mahameed <saeedm@nvidia.com>
>
> Selects which algorithm should be used by the NIC in order to decide rate of
> CQE compression dependeng on PCIe bus conditions.
>
> Supported values:
>
> 1) balanced, merges fewer CQEs, resulting in a moderate compression ratio
>     but maintaining a balance between bandwidth savings and performance
> 2) aggressive, merges more CQEs into a single entry, achieving a higher
>     compression rate and maximizing performance, particularly under high
>     traffic loads.
>

Hello,

I'm facing some issues when trying to use the devlink param introduced 
in this patch. I have a multihost system with two hosts per CX7.

My NIC is:
$ lshw -C net
   *-network
        description: Ethernet interface
        product: MT2910 Family [ConnectX-7]
        vendor: Mellanox Technologies

My fw version is: 28.43.1014

To reproduce the problem I simply read the current cqe_compress_type 
setting and then change it:

$ devlink dev param show pci/0000:56:00.0 name cqe_compress_type
pci/0000:56:00.0:
   name cqe_compress_type type driver-specific
     values:
       cmode permanent value balanced

$ devlink dev param set pci/0000:56:00.0 name cqe_compress_type value 
"aggressive" cmode permanent
kernel answers: Connection timed out

from dmesg:
[  257.111349] mlx5_core 0000:56:00.0: 
wait_func_handle_exec_timeout:1159:(pid 72061): cmd[0]: 
ACCESS_REG(0x805) No done completion
[  257.137072] mlx5_core 0000:56:00.0: wait_func:1189:(pid 72061): 
ACCESS_REG(0x805) timeout. Will cause a leak of a command resource
[  270.871521] mlx5_core 0000:56:00.0: mlx5_cmd_comp_handler:1709:(pid 
0): Command completion arrived after timeout (entry idx = 0).


subsequent attempts to use mstfwreset hang:

$ ./mstfwreset -y -d 56:00.0 reset
-E- Failed to send Register MFRL: Timed out trying to take the ICMD 
semaphore (520).

I can toggle the parameter ok using the mstconfig binary built from the 
mstflint github repo.

Let me know if I can provide any more information.

Daniel

  reply	other threads:[~2025-10-17 21:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-07  1:29 [PATCH V7 net-next 00/11] *devlink, mlx5: Add new parameters for link management and SRIOV/eSwitch configurations Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 01/11] devlink: Add 'total_vfs' generic device param Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 02/11] net/mlx5: Implement cqe_compress_type via devlink params Saeed Mahameed
2025-10-17 21:51   ` Daniel Zahka [this message]
2025-10-17 21:54     ` Daniel Zahka
2025-10-20  5:24       ` Tariq Toukan
2025-10-22 13:42         ` Dragos Tatulea
2025-10-22 16:26           ` Daniel Zahka
2025-09-07  1:29 ` [PATCH V7 net-next 03/11] net/mlx5: Implement devlink enable_sriov parameter Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 04/11] net/mlx5: Implement devlink total_vfs parameter Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 05/11] devlink: pass struct devlink_port * as arg to devlink_nl_param_fill() Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 06/11] devlink: Implement port params registration Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 07/11] devlink: Implement get/dump netlink commands for port params Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 08/11] devlink: Implement set netlink command " Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 09/11] devlink: Throw extack messages on param value validation error Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 10/11] devlink: Implement devlink param multi attribute nested data values Saeed Mahameed
2025-09-07  1:29 ` [PATCH V7 net-next 11/11] net/mlx5: Implement eSwitch hairpin per prio buffers devlink params Saeed Mahameed
2025-09-10  2:13 ` [PATCH V7 net-next 00/11] *devlink, mlx5: Add new parameters for link management and SRIOV/eSwitch configurations Jakub Kicinski
2025-09-10  2:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec51df17-260e-4ec9-a44a-9f0c3d3a2766@gmail.com \
    --to=daniel.zahka@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeed@kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).