netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Kyle Zeng <zengyhkyle@gmail.com>, dsahern@kernel.org
Cc: vfedorenko@novek.ru, davem@davemloft.net, netdev@vger.kernel.org,
	 ssuryaextr@gmail.com
Subject: Re: [PATCH net] fix null-deref in ipv4_link_failure
Date: Thu, 14 Sep 2023 11:17:40 +0200	[thread overview]
Message-ID: <ec738a108981c42604fa50f89c4551942b9e281b.camel@redhat.com> (raw)
In-Reply-To: <ZP/OjT62OGVxwa3t@westworld>

On Mon, 2023-09-11 at 19:35 -0700, Kyle Zeng wrote:
> Currently, we assume the skb is associated with a device before calling
> __ip_options_compile, which is not always the case if it is re-routed by
> ipvs.
> When skb->dev is NULL, dev_net(skb->dev) will become null-dereference.
> This patch adds a check for the edge case and switch to use the net_device
> from the rtable when skb->dev is NULL.
> 
> Fixes: ed0de45 ("ipv4: recompile ip options in ipv4_link_failure")

I'm sorry for the nit-picking, but please use 12 chars to identify the
blamed commit or we risk (future) conflicts.

Please also add a subsystem tag inside the subj. Finally include a
revision counter into prefix, alike:

[PATCH v3 net] ipv4: fix ...

(I'm not really sure about the correct counter here, since a few
versions flied without it)

Note that you can retain David's ack in the next revision.


Thanks!

Paolo


  parent reply	other threads:[~2023-09-14  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12  2:35 [PATCH net] fix null-deref in ipv4_link_failure Kyle Zeng
2023-09-12 15:58 ` David Ahern
2023-09-14  9:17 ` Paolo Abeni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-09-08  3:18 Kyle Zeng
2023-09-08 20:13 ` Vadim Fedorenko
2023-09-11  4:36 ` David Ahern
2023-09-11  6:09 ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec738a108981c42604fa50f89c4551942b9e281b.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ssuryaextr@gmail.com \
    --cc=vfedorenko@novek.ru \
    --cc=zengyhkyle@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).