From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0717334DCC7; Wed, 4 Mar 2026 15:51:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772639514; cv=none; b=VDTZQbTF2o+e7PMMsJEUYPNCJPU61+bTzpBXfMeqRs9G+c1EsD74fL+VqeJW15nZkRpDoPCuUEiv3BNYUj4tjp0muiCZ9Fy16XcK7MloPH3Bsc1zo0sf7T3U0HuQSDr76VoMgr7aVncU02XG/Njdq/QiR7rxvYPcwxSuRwbqmYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772639514; c=relaxed/simple; bh=wCvFJq9Lq2vO2torbTJLZMXCQnEtJhovSJOdtjbZSKg=; h=Message-ID:Subject:From:To:CC:Date:In-Reply-To:References: Content-Type:MIME-Version; b=N98MhAd3GOUm2fHDSnd70GaULysNX/lwjEWDnHrHAZ4cEiWWVzuTcEXgOxGGiJKXONkht9fTaSfKM+BcoUUVujc/Zhph1ediDNn3o9IxbR7n1e/xkiAfYp3dv6b36k1hhZryz0qTyN+2Rmehs7cOCE8NnlrMREZ30y6m7eDZSKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=gYtAH7jQ; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="gYtAH7jQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1772639513; x=1804175513; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=wCvFJq9Lq2vO2torbTJLZMXCQnEtJhovSJOdtjbZSKg=; b=gYtAH7jQAVLxMzOSO594YlgyA72vsNZ8AQxMrvZM/5O70W7DsPvAsaQF qt0CtmwDQBo/p/Rs/xVNImiwgGHXPecQbynLrIRegFB7GCEHipLoiMHLJ 22lnHdwaIRXXw2kI9WnK0E80T+e0Ff/kB67rQVQZ75pTBlnA1m9ZUh87m Kxjc1G52rzU/IC8NXGQbssU2X1K/aeyxXmJK1VI2xaWIAKnTbL0m7q1tX 1/6MMkimk7q20a6agbfVvD7GY1GNBfSs6S+Zj1LiSvxubsYMTIPu3W1yM A0OhyToYQgCKosi6DFLgsLKBoWG+cHO8b3Ze63nJ9MOVvB74CYAJTPrhd g==; X-CSE-ConnectionGUID: wxutpbsLTX+yxXic6b+o+A== X-CSE-MsgGUID: DIr10+/gQTWgcWiYnOCNgw== X-IronPort-AV: E=Sophos;i="6.21,324,1763449200"; d="scan'208";a="285599112" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2026 08:51:52 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.87.152) by chn-vm-ex1.mchp-main.com (10.10.87.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.35; Wed, 4 Mar 2026 08:51:21 -0700 Received: from DEN-DL-M77643.microsemi.net (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Wed, 4 Mar 2026 08:51:18 -0700 Message-ID: Subject: Re: [PATCH net-next 8/8] net: dsa: lan9645x: add port statistics From: Jens Emil Schulz Ostergaard To: Andrew Lunn , Vladimir Oltean CC: , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" , Simon Horman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Woojung Huh , "Russell King" , Steen Hegelund , Daniel Machon , , , Date: Wed, 4 Mar 2026 16:51:18 +0100 In-Reply-To: References: <20260303-dsa_lan9645x_switch_driver_base-v1-0-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-0-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-8-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-8-bff8ca1396f5@microchip.com> <20260303160159.efjtqzpa2w4awxht@skbuf> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-03-03 at 21:21 +0100, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know th= e content is safe >=20 > > > +void lan9645x_stats_get_stats64(struct lan9645x *lan9645x, int port, > > > + struct rtnl_link_stats64 *stats) > > > +{ > > > + u64 *port_cnt; > > > + > > > + /* Avoid stats update, as this is called very often by DSA. */ > > > + mutex_lock(&lan9645x->stats->hw_lock); > >=20 > > This is atomic context, you can't acquire a mutex which may be held by = a > > process which sleeps, which also puts you to sleep for it. >=20 > Which suggests no testing has been done with kernel configuration > options enabled which does checks for this, deadlock detection, etc. >=20 > I would suggest PROVE_LOCKING, DEBUG_SPINLOCK, DEBUG_MUTEXES, > DEBUG_ATOMIC_SLEEP. >=20 > Andrew I will run our testsuite with those options enabled. Thanks, Emil