From: Dan Carpenter <dan.carpenter@linaro.org>
To: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: call stmmac_remove_config_dt() in error paths in stmmac_probe_config_dt()
Date: Tue, 17 Dec 2024 14:27:26 +0300 [thread overview]
Message-ID: <ec8509c2-1124-4f8a-b831-459d084ac726@stanley.mountain> (raw)
In-Reply-To: <20241217033243.3144184-1-joe@pf.is.s.u-tokyo.ac.jp>
On Tue, Dec 17, 2024 at 12:32:43PM +0900, Joe Hattori wrote:
> Also, remove the first argument of stmmac_remove_config_dt() as it is not
> used.
Don't do that. It makes the patch difficult to review.
regards,
dan carpenter
next prev parent reply other threads:[~2024-12-17 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 3:32 [PATCH] net: stmmac: call stmmac_remove_config_dt() in error paths in stmmac_probe_config_dt() Joe Hattori
2024-12-17 10:58 ` Krzysztof Kozlowski
2024-12-18 3:24 ` Joe Hattori
2024-12-17 11:27 ` Dan Carpenter [this message]
2024-12-18 3:27 ` Joe Hattori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec8509c2-1124-4f8a-b831-459d084ac726@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=kuba@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox