From: David Ahern <dsahern@gmail.com>
To: Andy Roulin <aroulin@cumulusnetworks.com>, netdev@vger.kernel.org
Cc: nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com,
j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH iproute2-next v3 2/2] iplink: bond: print lacp actor/partner oper states as strings
Date: Thu, 2 Jan 2020 10:56:57 -0700 [thread overview]
Message-ID: <ec9976a8-7084-687d-a7eb-7df07bd85196@gmail.com> (raw)
In-Reply-To: <1577794502-8063-3-git-send-email-aroulin@cumulusnetworks.com>
On 12/31/19 5:15 AM, Andy Roulin wrote:
> The 802.3ad/LACP actor/partner operating states are only printed as
> numbers, e.g,
>
> ad_actor_oper_port_state 15
>
> Add an additional output in ip link show that prints a string describing
> the individual 3ad bit meanings in the following way:
>
> ad_actor_oper_port_state_str <active,short_timeout,aggregating,in_sync>
>
> JSON output is also supported, the field becomes a json array:
>
> "ad_actor_oper_port_state_str":
> ["active","short_timeout","aggregating","in_sync"]
>
> Signed-off-by: Andy Roulin <aroulin@cumulusnetworks.com>
> ---
> ip/iplink_bond_slave.c | 36 ++++++++++++++++++++++++++++++++----
> 1 file changed, 32 insertions(+), 4 deletions(-)
>
Fixed up a space before tabs in the macro and applied to iproute2-next.
Please run checkpatch on patches.
prev parent reply other threads:[~2020-01-02 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 12:15 [PATCH iproute2-next v3 0/2] pretty-print LACP slave state Andy Roulin
2019-12-31 12:15 ` [PATCH iproute2-next v3 1/2] include/uapi: update bonding kernel header Andy Roulin
2019-12-31 12:15 ` [PATCH iproute2-next v3 2/2] iplink: bond: print lacp actor/partner oper states as strings Andy Roulin
2020-01-02 17:56 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec9976a8-7084-687d-a7eb-7df07bd85196@gmail.com \
--to=dsahern@gmail.com \
--cc=andy@greyhouse.net \
--cc=aroulin@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).