From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74A4C433E0 for ; Fri, 22 Jan 2021 21:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B307323B04 for ; Fri, 22 Jan 2021 21:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729347AbhAVVyA (ORCPT ); Fri, 22 Jan 2021 16:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728411AbhAVVxj (ORCPT ); Fri, 22 Jan 2021 16:53:39 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23A4AC06174A; Fri, 22 Jan 2021 13:52:53 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id e6so4749450pjj.1; Fri, 22 Jan 2021 13:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XOLrhjmC6rVAyRgBoStXhP1O5SrIITRCLdMBS4GnOjw=; b=HL9YDTTMTFQ1M79KDKrjqtQEQEk4Z+hl8oxK7gcqeCGHYVKlZI76Zt0YmjOu/fx5nT XTeFVUbuHVfRB4itSsezJkmDA4gPlrlQUo0vrRVY/H5Wro5DRCPcuZDsJS1wB9L5x0GQ sewnUeWQyuQyB01UBZk3zBb0Mu6X0/XvFNwj3iPNFzaQZ6MlWQ6KsBXlc5W/vPY24bYF TAs0vwtOEMQ5DybacbrM1To1pHHbvquGu7L5KVdJ1d3SHgI6CbN3vmUR7SPSxJMOhTMn R5e5snPTTWe3U02lYsdmpKwEBwGr/Fs/au6GgeNavLMmivY8eRIOWaZLY/Bnj+BvfPT9 Alow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XOLrhjmC6rVAyRgBoStXhP1O5SrIITRCLdMBS4GnOjw=; b=Qj9WNcbkGfbadgeVS4SHddzmk0WFjda4mFu3uH7pAqngAxBDhL7+5kzc7+kTe/qnfL aZGYvL6Q40c1Dv3vH6mLwCrNqvxSgctl4//6R5KHab3kzM0FA+5bQ/BBoxLj+HLsacm1 fe5EbOS68K4V40uac1kfh5IXq9QJjuENUKcoTpr2KKix3xPglw6Psnk+sx2AJ7BZLU7L OcEnyi4LMK3YF1DqMeiR1qTG0vtrnGUuaOQhH+8wpJiyuClvZgHeRHYnYbNumU8bDrEM glWCPdqX6gtvogtLUzUcdwU1s1NOsIWTeeJEm9iaf1yqYYLrY6yUInGGhhamlODb/BkV MhZQ== X-Gm-Message-State: AOAM533QJUxrz+CH2/b9Bq1rE6hglEpQFvPV+LD9XIEsmVfmnSAnKujz 3uWQ87xgbpXi9nIRcJt9L7lrpdTpfs0= X-Google-Smtp-Source: ABdhPJxD11rUWI5xGSGGel5IJuEUgdIOdgJd7sPLvnblZgxE4Zh55ELJTfqxZrBzkoaZnv/Gmpkd8w== X-Received: by 2002:a17:90a:a608:: with SMTP id c8mr7587846pjq.61.1611352372305; Fri, 22 Jan 2021 13:52:52 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 78sm5978550pfx.127.2021.01.22.13.52.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 13:52:51 -0800 (PST) Subject: Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices To: Sergej Bauer , netdev@vger.kernel.org Cc: andrew@lunn.ch, "David S. Miller" , Jakub Kicinski , Bryan Whitehead , UNGLinuxDriver@microchip.com, Simon Horman , Mark Einon , Madalin Bucur , Arnd Bergmann , Masahiro Yamada , linux-kernel@vger.kernel.org References: <20210122214247.6536-1-sbauer@blackbox.su> From: Florian Fainelli Message-ID: Date: Fri, 22 Jan 2021 13:52:48 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210122214247.6536-1-sbauer@blackbox.su> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/22/2021 1:42 PM, Sergej Bauer wrote: > From: sbauer@blackbox.su > > v1->v2: > switch to using of fixed_phy as was suggested by Andrew and Florian > also features-related parts are removed > > Previous versions can be found at: > v1: > initial version > https://lkml.org/lkml/2020/9/17/1272 > > Signed-off-by: Sergej Bauer You are not explaining why you need this and why you are second guessing the fixed PHY MII emulation that already exists. You really need to do a better job at describing your changes and why the emulation offered by swphy.c is not enough for your use case. -- Florian