From: Paolo Abeni <pabeni@redhat.com>
To: Kyle Zeng <zengyhkyle@gmail.com>,
davem@davemloft.net, dsahern@kernel.org, netdev@vger.kernel.org
Cc: ssuryaextr@gmail.com
Subject: Re: [PATCH] don't assume the existence of skb->dev when trying to reset ip_options in ipv4_send_dest_unreach
Date: Thu, 07 Sep 2023 13:03:52 +0200 [thread overview]
Message-ID: <ecde5e34c6f3a8182f588b3c1352bf78b69ff206.camel@redhat.com> (raw)
In-Reply-To: <ZPk41vtxHK/YnFUs@westworld>
On Wed, 2023-09-06 at 19:43 -0700, Kyle Zeng wrote:
> Currently, we assume the skb is associated with a device before calling __ip_options_compile, which is not always the case if it is re-routed by ipvs.
> When skb->dev is NULL, dev_net(skb->dev) will become null-dereference.
> Since we know that all the options will be set to IPOPT_END, which does
> not depend on struct net, we pass NULL to it.
It's not clear to me why we can infer the above. Possibly would be more
safe to skip entirely the __ip_options_compile() call?!?
Please at least clarify the changelog and trim it to 72 chars.
Additionally trim the subj to the same len and include the target tree
(net) into the subj prefix.
Thanks!
Paolo
next prev parent reply other threads:[~2023-09-07 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 2:43 [PATCH] don't assume the existence of skb->dev when trying to reset ip_options in ipv4_send_dest_unreach Kyle Zeng
2023-09-07 11:03 ` Paolo Abeni [this message]
2023-09-07 22:53 ` Kyle Zeng
2023-09-08 1:08 ` [PATCH] fix null-deref in ipv4_link_failure kernel test robot
2023-09-08 1:40 ` kernel test robot
2023-09-08 1:45 ` [PATCH] don't assume the existence of skb->dev when trying to reset ip_options in ipv4_send_dest_unreach Kyle Zeng
2023-09-08 3:15 ` David Ahern
2023-09-07 14:39 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecde5e34c6f3a8182f588b3c1352bf78b69ff206.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
--cc=zengyhkyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).