From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16C8C10F0E for ; Sun, 7 Apr 2019 20:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2489206C0 for ; Sun, 7 Apr 2019 20:48:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mIilBfck" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbfDGUsn (ORCPT ); Sun, 7 Apr 2019 16:48:43 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39789 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbfDGUsn (ORCPT ); Sun, 7 Apr 2019 16:48:43 -0400 Received: by mail-wr1-f68.google.com with SMTP id j9so13930546wrn.6 for ; Sun, 07 Apr 2019 13:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ri1cr14M4G0qutMlKQ01RRuoGpeGpaxSObSnStKZmHo=; b=mIilBfckXPA0hGHAmv8eAmEn1dcJhg0yZlKSqDySntye0XBP3t/lLKSpLAAXp1IwP9 zizhIK82uYLvWjNmRpOVtPrvgBytJcQR85Nl1NzBWb4uRqdV2QWOiN+frzw52rbQBB9g 6MPbNzIvQGMUpbiL0Eb0uymvpMMaZTPGyIHleREOkjBLHhOiJLMRe2BXF+NCfsR+Z2H6 nZpJceRJmdAMDrHH7tiRiXDNA5TmWEw/MxOjC+ygpHBnUa7nwz5Z5HEtLTOfJUEQeQaN InY9I37MPfwP8VClP8WNElM53UYAI3xp7MVv/zGWidq1g8lkk+17sY3lGtehgmqAbw0p NDAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ri1cr14M4G0qutMlKQ01RRuoGpeGpaxSObSnStKZmHo=; b=TF8TEJZRATUC4ViRit7wdHWEFXR4A/op+xPtZwf/VykFWqKDEci068zIgvFcmu1MNL pkZDIEU2jFomB9tSbJcFfd84wKDouzqUPARb8W82al3doZTnr93leteyPAXN0xc4bpra cYlf3N8l+FTGPXacLv0Ftka+HBjG3ORKb/+H2J/XRWWs75fhXOpah0oFNBpoZtYnSCew 20N36pSB6MvSefcIEvbJ2U1Awnc3p6NJnsHNGFpHJ+EEZ1PIQCJJ3oR8hh9L6JLuSxsI v0nF0zr9fsc71oAsakDNHYXqBHXPtchnLfygM4f1iSadjqH3R5JGS1WQrL3N2j44jvtZ quAw== X-Gm-Message-State: APjAAAV2Xg1ILLbi/TzvFCdntpjvHteHWIbsdnAgO4mP+XZga9Z0+XVk ZLC4BS2hqW5dAS5Zd39p81M= X-Google-Smtp-Source: APXvYqzA5bneIYSk+mLlS1vEAqEQNhKsuslVf6t5UChBwz2cY+xN/2SK4qspM9nFyL9QMDZw8GMXcA== X-Received: by 2002:adf:df92:: with SMTP id z18mr7325851wrl.239.1554670121344; Sun, 07 Apr 2019 13:48:41 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:cd3d:7432:4830:ab0a? (p200300EA8BE1DD00CD3D74324830AB0A.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:cd3d:7432:4830:ab0a]) by smtp.googlemail.com with ESMTPSA id x14sm10221996wmj.3.2019.04.07.13.48.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Apr 2019 13:48:40 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection To: Florian Fainelli , Andrew Lunn , David Miller , Ray Jui , Scott Branden , Richard Cochran , Kevin Hilman , Heiko Stuebner Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org References: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> <53f5d96e-4594-7a32-792d-4837479da7f2@gmail.com> From: Heiner Kallweit Message-ID: Date: Sun, 7 Apr 2019 22:48:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <53f5d96e-4594-7a32-792d-4837479da7f2@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 07.04.2019 22:31, Florian Fainelli wrote: > > > On 4/7/2019 2:57 AM, Heiner Kallweit wrote: >> Recently genphy_read_abilities() has been added that dynamically detects >> clause 22 PHY abilities. I *think* this detection should work with all >> supported PHY's, at least for the ones with basic features sets, i.e. >> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these >> features explicitly and rely on phylib feature detection. >> >> I don't have access to most of these PHY's, therefore I'd appreciate >> regression testing. > > The nice thing about the features is that we can right away tell which > PHY entries are Fast Ethernet/Gigabit etc... so if you remove that > assignment, we would need at least a standardized comment allowing us to > quickly grep for that information. > Yes, that gets lost. Well, in a lot (most?) of cases you still have it in the name. But who needs this information what for? At runtime e.g. ethtool tells what's supported. And for all PHY's w/o dedicated driver that are using the genphy driver you don't know anyway. For c45 PHY's this would become even more tricky as they can support much more speeds.