From: Johannes Berg <johannes@sipsolutions.net>
To: syzbot <syzbot+a4aee3f42d7584d76761@syzkaller.appspotmail.com>,
davem@davemloft.net, kvalo@codeaurora.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net,
netdev@vger.kernel.org, pabeni@redhat.com,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in hwsim_new_radio_nl
Date: Tue, 14 Apr 2020 12:38:22 +0200 [thread overview]
Message-ID: <ed2b00dfda5b6ce46a2c2a33093ee56f77af6a8f.camel@sipsolutions.net> (raw)
In-Reply-To: <000000000000cb517b05a32c917b@google.com> (sfid-20200413_160506_506947_12BA215F)
Hi syzbot keepers,
On Mon, 2020-04-13 at 07:05 -0700, syzbot wrote:
> syzbot has bisected this bug to:
>
> commit 01cacb00b35cb62b139f07d5f84bcf0eeda8eff6
> Author: Paolo Abeni <pabeni@redhat.com>
> Date: Fri Mar 27 21:48:51 2020 +0000
>
> mptcp: add netlink-based PM
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10225bb3e00000
This is, fairly obviously, incorrect. Same with the bisection for
6693adf1698864d21734, which is really the same underlying problem as
this one (though at a different code site).
However, it stands out that this was bisected to a commit that adds a
new generic netlink family in both cases.
This makes sense - the reproducer identifies the family by *number*, but
that number isn't stable, generic netlink families should be identified
by *name*.
Perhaps somehow syzbot could be taught that, so that the bisection is
stable across kernels with different generic netlink families
registered?
Alternatively, we _could_ add some kind of stable ID mode, but I'm not
sure we really want to ... since that would mean people start hardcoding
IDs?
johannes
next prev parent reply other threads:[~2020-04-14 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 16:32 WARNING in hwsim_new_radio_nl syzbot
2020-04-13 6:15 ` syzbot
2020-04-13 14:05 ` syzbot
2020-04-14 10:38 ` Johannes Berg [this message]
2020-04-15 15:16 ` Dmitry Vyukov
2020-04-14 10:42 ` Paolo Abeni
2020-04-14 10:59 ` syzbot
2020-04-14 11:11 ` Johannes Berg
2020-04-14 12:55 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed2b00dfda5b6ce46a2c2a33093ee56f77af6a8f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+a4aee3f42d7584d76761@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).