Netdev List
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Weiming Shi <bestswngs@gmail.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	Jiri Olsa <jolsa@kernel.org>,
	Emil Tsalapatis <emil@etsalapatis.com>,
	Ihor Solodrai <ihor.solodrai@linux.dev>,
	John Fastabend <john.fastabend@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Xiang Mei <xmei5@asu.edu>
Subject: Re: [PATCH v4 2/2] selftests/bpf: cover stale CB after LWT IP encapsulation
Date: Tue, 22 Sep 2026 15:37:53 +0200	[thread overview]
Message-ID: <ed33494b-24c2-4587-8830-16951d74dd6e@iogearbox.net> (raw)
In-Reply-To: <20260921173910.90847-3-bestswngs@gmail.com>

On 9/21/26 7:39 PM, Weiming Shi wrote:
> Add compact regression coverage to the existing LWT IP encapsulation
> test. Send an IPv4 ping with a Record Route option through an ingress LWT
> program which prepends a TTL-one IPv4 header, then observe __icmp_send()
> with fentry and verify that the restored protocol control block no longer
> contains the inner header's cached option offsets.
> 
> Read ctx->cb[0] in the LWT program so the test exercises
> bpf_prog_run_save_cb()'s save/restore path before the post-run check.
> 
> Link: https://lore.kernel.org/bpf/DLKB3UXOH0IS.1UL8NV9HSJFXG@gmail.com/
> Signed-off-by: Weiming Shi <bestswngs@gmail.com>
Did you /actually/ try to run the test you submitted?

BPF CI :

     [...]
     lwt_ip_encap_vxlan:PASS:setup network 0 nsec
     setup_vxlan_routes:PASS:open ns3 for vxlan 0 nsec
     setup_vxlan_routes:PASS:ip    a add 172.16.17.100/32  dev veth8 0 nsec
     setup_vxlan_routes:PASS:ip -6 a add fb11::1/128 dev veth8 0 nsec
     setup_vxlan_routes:PASS:ip link add vxlan4 type vxlan id 1 dstport 4789 local 172.16.17.100 dev veth8 nolearning noudpcsum 0 nsec
     setup_vxlan_routes:PASS:ip link set vxlan4 up 0 nsec
     setup_vxlan_routes:PASS:ip link add vxlan6 type vxlan id 1 dstport 4789 local fb11::1 dev veth8 nolearning udp6zerocsumrx 0 nsec
     setup_vxlan_routes:PASS:ip link set vxlan6 up 0 nsec
     setup_vxlan_routes:PASS:ip -n ns-lwt-ip-encap-1-0000128    route add 172.16.17.100/32  dev veth5 via 172.16.6.100 0 nsec
     setup_vxlan_routes:PASS:ip -n ns-lwt-ip-encap-2-0000128    route add 172.16.17.100/32  dev veth7 via 172.16.8.100 0 nsec
     setup_vxlan_routes:PASS:ip -n ns-lwt-ip-encap-1-0000128 -6 route add fb11::1/128 dev veth5 via fb06::1 0 nsec
     setup_vxlan_routes:PASS:ip -n ns-lwt-ip-encap-2-0000128 -6 route add fb11::1/128 dev veth7 via fb08::1 0 nsec
     lwt_ip_encap_vxlan:PASS:setup vxlan routes 0 nsec
     lwt_ip_encap_vxlan:PASS:test_lwt_ip_encap__open 0 nsec
     libbpf: prog 'bpf_lwt_encap_stale': missing BPF prog type, check ELF section name 'encap_stale'
     libbpf: prog 'bpf_lwt_encap_stale': failed to load: -EINVAL
     libbpf: failed to load object 'test_lwt_ip_encap'
     libbpf: failed to load BPF skeleton 'test_lwt_ip_encap': -EINVAL
     lwt_ip_encap_vxlan:FAIL:test_lwt_ip_encap__load unexpected error: -22 (errno 22)

      parent reply	other threads:[~2026-09-22 13:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 17:39 [PATCH v4 0/2] bpf: clear stale IPv4 options after LWT encapsulation Weiming Shi
2026-09-21 17:39 ` [PATCH v4 1/2] " Weiming Shi
2026-09-21 17:39 ` [PATCH v4 2/2] selftests/bpf: cover stale CB after LWT IP encapsulation Weiming Shi
2026-09-21 18:38   ` bot+bpf-ci
2026-09-22 13:37   ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed33494b-24c2-4587-8830-16951d74dd6e@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bestswngs@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=emil@etsalapatis.com \
    --cc=horms@kernel.org \
    --cc=ihor.solodrai@linux.dev \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=xmei5@asu.edu \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox