* [PATCH net-next] net/smc: Print function name in smcr_link_down tracepoint
@ 2021-11-03 12:48 Tony Lu
2021-11-09 16:17 ` Karsten Graul
0 siblings, 1 reply; 2+ messages in thread
From: Tony Lu @ 2021-11-03 12:48 UTC (permalink / raw)
To: kgraul; +Cc: kuba, davem, guwen, netdev, linux-s390, linux-rdma
This makes the output of smcr_link_down tracepoint easier to use and
understand without additional translating function's pointer address.
It prints the function name with offset:
<idle>-0 [000] ..s. 69.087164: smcr_link_down: lnk=00000000dab41cdc lgr=000000007d5d8e24 state=0 rc=1 dev=mlx5_0 location=smc_wr_tx_tasklet_fn+0x5ef/0x6f0 [smc]
Link: https://lore.kernel.org/netdev/11f17a34-fd35-f2ec-3f20-dd0c34e55fde@linux.ibm.com/
Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
Reviewed-by: Wen Gu <guwen@linux.alibaba.com>
---
net/smc/smc_tracepoint.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/smc/smc_tracepoint.h b/net/smc/smc_tracepoint.h
index b4c36795a928..ec17f29646f5 100644
--- a/net/smc/smc_tracepoint.h
+++ b/net/smc/smc_tracepoint.h
@@ -99,7 +99,7 @@ TRACE_EVENT(smcr_link_down,
__entry->location = location;
),
- TP_printk("lnk=%p lgr=%p state=%d dev=%s location=%p",
+ TP_printk("lnk=%p lgr=%p state=%d dev=%s location=%pS",
__entry->lnk, __entry->lgr,
__entry->state, __get_str(name),
__entry->location)
--
2.19.1.6.gb485710b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/smc: Print function name in smcr_link_down tracepoint
2021-11-03 12:48 [PATCH net-next] net/smc: Print function name in smcr_link_down tracepoint Tony Lu
@ 2021-11-09 16:17 ` Karsten Graul
0 siblings, 0 replies; 2+ messages in thread
From: Karsten Graul @ 2021-11-09 16:17 UTC (permalink / raw)
To: Tony Lu; +Cc: kuba, davem, guwen, netdev, linux-s390, linux-rdma
On 03/11/2021 13:48, Tony Lu wrote:
> This makes the output of smcr_link_down tracepoint easier to use and
> understand without additional translating function's pointer address.
>
> It prints the function name with offset:
>
> <idle>-0 [000] ..s. 69.087164: smcr_link_down: lnk=00000000dab41cdc lgr=000000007d5d8e24 state=0 rc=1 dev=mlx5_0 location=smc_wr_tx_tasklet_fn+0x5ef/0x6f0 [smc]
>
> Link: https://lore.kernel.org/netdev/11f17a34-fd35-f2ec-3f20-dd0c34e55fde@linux.ibm.com/
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> Reviewed-by: Wen Gu <guwen@linux.alibaba.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-09 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-03 12:48 [PATCH net-next] net/smc: Print function name in smcr_link_down tracepoint Tony Lu
2021-11-09 16:17 ` Karsten Graul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).